-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saving a file is hanging indefinitely #88
Comments
It is weird because the extension does not interfere saving of files, I also failed to reproduce it, so it would be great if someone could help with that. |
I attempted to reproduce by checking out the typescript and vuejs/core repositories. As both are pretty large and vuejs/core is a monorepo. I cannot reproduce any problems with the extensions. Running the extension host profile does not show any performance issues with the extension. So far it seems this issue and #102 seem to use a macbook, I use a windows machine. Doubt its related but if more people raise issues it could be worth asking.
This seems interesting to me. Maybe it has to do with truncated errors? Something like a recursion with regular expressions? It all seems to be handled here: pretty-ts-errors/src/format/formatTypeBlock.ts Lines 54 to 76 in 2531440
I don't see any reason for the extension to stall in a seemingly infinite loop. |
Just an FYI, I run Windows, Linux, and macOS and it happens on all three for me, so it doesn't seem to be platform specific. I see this issue most often when moving a typescript file which triggers vscode to update the |
@ChristopherHaws Thanks for the addition, that is helpful. I'm gonna see if I can reproduce it by moving a file causing TS to update the imports. |
Describe the bug
Hi, since today this extension has been causing the save file action to hang indefinitely.
I deactivated all my VSCode extensions and this one seems to cause the issue. I don't have any more insight but I'll be happy to send more if someone provides guidance.
I use the v0.5.2 and also tried the v0.5.1 which causes the same issue.
Here's my VSCode info:
Version: 1.84.2
Commit: 1a5daa3a0231a0fbba4f14db7ec463cf99d7768e
Date: 2023-11-09T10:52:57.054Z (1 wk ago)
Electron: 25.9.2
ElectronBuildId: 24603566
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 21.5.0
Expected behavior
Saving a file should be instant.
Screenshots
The text was updated successfully, but these errors were encountered: