Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release workflow reports 'No merged PRs found since last release.' #28

Open
2 tasks done
philnewm opened this issue Oct 8, 2024 · 1 comment
Open
2 tasks done

Comments

@philnewm
Copy link
Collaborator

philnewm commented Oct 8, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Expected Behavior:

Check latest workflow run

  • 4 Commits happened after the latest release 0.1.1
  • One of them is an actual PR - got merged just before the latest release
  • Might be an edge case

Release workflow should pick up the changes and create a release.

Current Behavior:

Workflow reports: No merged PRs found since last release. in job increment version

Steps To Reproduce:

  1. Check workflow in syncsketch

Are there any labels you wish to add?

  • I have added the relevant labels to the bug report.

Relevant log output:

No response

Additional context:

No response

@philnewm philnewm added the bug Something isn't working label Oct 8, 2024
@philnewm
Copy link
Collaborator Author

philnewm commented Oct 8, 2024

I just did a few checks:

The latest release (0.1.1) was created at (running gh release view --json publishedAt --repo ynput/ayon-syncsketch)

{
  "publishedAt": "2024-10-07T14:35:57Z"
}

While the release workflow was triggered first at (running gh run list --workflow "🚀 Release Trigger" --limit 1 --json createdAt --jq '.[0].createdAt' --repo ynput/ayon-syncsketch)

2024-10-07T15:30:31Z

So about an hour later.

So from the details I was able to figure out here so far it seems like you created release 0.1.1 before you ran the Release Trigger workflow if I'm not mistaken.

I assume there were no other merged PRs since release 0.1.1- so I need to know, was was your intention here.
And just a side note: the release workflow only cares about merged PRs and not not about single commits since commits don't carry any required metadata for releases.

@jakubjezek001 let me know what you wanted to do so we can figure it out :D

@mkolar mkolar removed the bug Something isn't working label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants