suppress security lint warnings for a while. (istio#1830)

* suppress security lint warnings for a while.

Those suppression should be removed once istio#1446 is fixed.

* exclude mixer/adapter/svcctrl

* a few more suppressions (and a run of fmt.sh)

* fix on config

* remove mixer/pkg/il suppression

Author: jmuk

bin/linters.sh

@@ -24,7 +24,7 @@ docker run\
   -w /go/src/istio.io/istio\
   gcr.io/mukai-istio/linter:bbcfb47f85643d4f5a7b1c092280d33ffd214c10\
   --config=./lintconfig.json \
-  ./... || true
+  ./...
 echo 'linters OK'
 
 echo 'Checking licences'

lintconfig.json

@@ -24,6 +24,8 @@
     "enableGC": true,
     "exclude": [
         "vendor",
+        "mixer/adapter/svcctrl",
+        "^security",
         ".pb.go",
         "mixer/pkg/config/proto/combined.go",
         ".*.gen.go",

lintconfig_base.json

@@ -27,6 +27,8 @@
     ],
     "exclude": [
         "vendor",
+        "mixer/adapter/svcctrl",
+        "^security",
         ".pb.go",
         "mixer/pkg/config/proto/combined.go",
         ".*.gen.go",

mixer/adapter/svcctrl/reportbuilder_test.go

@@ -15,13 +15,12 @@
 package svcctrl
 
 import (
+	"reflect"
 	"testing"
 	"time"
 
 	sc "google.golang.org/api/servicecontrol/v1"
 
-	"reflect"
-
 	"istio.io/istio/mixer/adapter/svcctrl/template/svcctrlreport"
 )
 

mixer/pkg/adapter/requestData_test.go

@@ -50,7 +50,7 @@ func TestNewContextWithRequestData(t *testing.T) {
 func TestRequestDataFromContextWithCollidingInt0Key(t *testing.T) {
 	badKey := 0
 	wantBadKeyData := "some data associated with bad key"
-	ctx := context.WithValue(context.Background(), badKey, wantBadKeyData)
+	ctx := context.WithValue(context.Background(), badKey, wantBadKeyData) // nolint: golint
 
 	wantGoodKeyData := &RequestData{DestinationService: Service{FullName: "foo.bar"}}
 	ctx = context.WithValue(ctx, requestDataKey, wantGoodKeyData)