Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Cannot highlight cross-domain iframe #29

Open
yiminzme opened this issue Jan 18, 2022 · 2 comments
Open

[Bug] Cannot highlight cross-domain iframe #29

yiminzme opened this issue Jan 18, 2022 · 2 comments
Labels
good first issue Good for newcomers

Comments

@yiminzme
Copy link
Owner

For example, in this example, when searching "python" in Multi Highlight, we expect both "python" in the webpage to be highlighted. But it is not the case.
20220118capture

I think it is because Multi Highlight currently doesn't work with the iframe HTML element. The red box highlight the location of iframe, and text in it doesn't seem to be searchable.

@yiminzme yiminzme added Bug PR Welcome Extra attention is needed labels Jan 18, 2022
@yiminzme
Copy link
Owner Author

yiminzme commented Jun 7, 2022

duplicate #41

@yiminzme yiminzme closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2022
@yiminzme yiminzme reopened this Jun 24, 2022
@yiminzme yiminzme changed the title Not working in certain pages Cannot highlight cross-domain iframe Jun 24, 2022
@yiminzme
Copy link
Owner Author

One more website that doesn't work (can be used for testing)
https://docs.oracle.com/javase/8/docs/api/

@yiminzme yiminzme changed the title Cannot highlight cross-domain iframe [Bug] Cannot highlight cross-domain iframe Jun 27, 2022
@yiminzme yiminzme removed Bug labels Jun 27, 2022
@yiminzme yiminzme added good first issue Good for newcomers and removed PR Welcome Extra attention is needed labels Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant