Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: "bower-asset/punycode": "^2.2" dependency is not valid #20283

Closed
olegbaturin opened this issue Nov 26, 2024 · 10 comments
Closed

Bug: "bower-asset/punycode": "^2.2" dependency is not valid #20283

olegbaturin opened this issue Nov 26, 2024 · 10 comments
Milestone

Comments

@olegbaturin
Copy link
Contributor

olegbaturin commented Nov 26, 2024

Since 2.0 "mathiasbynens/punycode.js" is a commonJS lib and can't be used in the browser.

module.exports = punycode;

#20009

To reproduce an error configure the email validator for the form field like this

['email', 'email', 'enableIDN' => true],

and try to open the page with the form
image

@olegbaturin olegbaturin changed the title bug "bower-asset/punycode": "^2.2" dependency is not valid Bug: "bower-asset/punycode": "^2.2" dependency is not valid Nov 26, 2024
@mtangoo
Copy link
Contributor

mtangoo commented Nov 26, 2024

Does it go away if 'enableIDN' => false?

@samdark
Copy link
Member

samdark commented Nov 26, 2024

@mtangoo yes, likely as in this case the lib isn't used.

@samdark
Copy link
Member

samdark commented Nov 26, 2024

I wonder how did it work for a year+...

@samdark samdark added this to the 2.0.52 milestone Nov 26, 2024
@samdark
Copy link
Member

samdark commented Nov 26, 2024

We can force using older version.

@mtangoo
Copy link
Contributor

mtangoo commented Nov 26, 2024

We can force using older version.

I will try to check and fingure out how it did and may be get some solution

@mtangoo
Copy link
Contributor

mtangoo commented Nov 26, 2024

I have found this, which no longer appears on README.
mathiasbynens/punycode.js@28de93e

This project provides a CommonJS module that uses ES6 features and an ES6 module, which work in modern Node versions and browsers. For the old version that offers the same functionality in a UMD build with support for older pre-ES6 runtimes, including Rhino, Ringo, and Narwhal, see v1.4.1

Am not sure why it is no longer there.

@mtangoo
Copy link
Contributor

mtangoo commented Nov 26, 2024

After checking releases page I found this:

v2.0.0
This release drops support for old environments. Punycode.js v2.0.0 targets Node.js v6+ and nothing else. For the old version that offers the same functionality with broader support, including Rhino, Ringo, Narwhal, and web browsers, see v1.4.1.

@mtangoo
Copy link
Contributor

mtangoo commented Nov 26, 2024

Looks like we have to pin the version to exactly 1.4.x

@mtangoo
Copy link
Contributor

mtangoo commented Nov 26, 2024

@olegbaturin can you test #20284 if the issue is fixed?

@olegbaturin
Copy link
Contributor Author

@olegbaturin can you test #20284 if the issue is fixed?

with 1.4.1 it works fine

@mtangoo mtangoo closed this as completed Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants