Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensitive headers logged in info log #235

Open
yii-bot opened this issue Jul 6, 2018 · 0 comments
Open

Sensitive headers logged in info log #235

yii-bot opened this issue Jul 6, 2018 · 0 comments
Labels
ext:authclient status:ready for adoption Feel free to implement this issue. type:enhancement Enhancement

Comments

@yii-bot
Copy link

yii-bot commented Jul 6, 2018

This issue has originally been reported by @sanjakovac at yiisoft/yii2#16488.
Moved here by @samdark.


What steps will reproduce the problem?

  • Turn on info log in your application
  • Use function Yii/authclient/BaseOAuth.SendRequest to do Http POST request

What is the expected result?

Yii/httpclient/StreamTransport.send should log only basic information about request.
Token should not be logged in info log, since it may contain sensitive information. Values of headers carrying sensitive information, should be obfuscated.

What do you get instead?

Yii/httpclient/StreamTransport.send will log all the headers including username/password if it was sent with request.

Additional info

Q A
Yii httpclient version 2.0.6.0
PHP version 7.0
Operating system MacOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext:authclient status:ready for adoption Feel free to implement this issue. type:enhancement Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants