ActionColumn buttons (by default) reset filters

[vologab]

What steps will reproduce the problem?

1. Create GridView with ActionColumn and filters/sorting features.
2. Select some filters and sort some columns
3. Click button in ActionColumn
4. As result - all filters reseted

What is the expected result?

Filters/Sorters should be saved/restored after clicking buttons in action column.

What do you get instead?

All filters reseted, after clicking actionColumn button.

As temporary solution, it's possible use closure in action column

[
'class' => '\yii\grid\ActionColumn',
'urlCreator' => function ($action, $model, $key, $index) {

 $request = \Yii::$app->getRequest();
 $paramsFromRequest = $request instanceof \yii\web\Request ? $request->getQueryParams() : [];

$params = is_array($key) ? $key : ['id' => (string) $key];
$params[0] = \Yii::$app->controller->id . '/' . $action;

return \Yii::$app->urlManager->createUrl(array_merge($paramsFromRequest, $params));
]

Additional info

Method createUrl() also used in Pagination.php, Sort.php, but in these classes for creating Url is used current parameters from request, so we don't have problems with resetting filters/sorting.

But for action column we should use slightly different solution because, creteUrl will be executed for each row/column, so we need params 'caching' (may be in GridView widget) from request for avoiding $paramsFromRequest = $request instanceof \yii\web\Request ? $request->getQueryParams() : []; calculating in each row.

Q	A
Yii version	2.0.7-372-g5921865
PHP version	PHP 5.6.11
Operating system	Ubuntu

[samdark]

yiisoft/yii2#11320

[samdark]

Need a test that verifies such behavior i.e. sorting and filtering is taken into account when generating URL for an action button.

[glpzzz]

4. As result - all filters reseted

I'm not clear on this part. As a result the action is performed (navigate to view/edit/delete). And it's depending on the action which page is rendered next.

Assuming the default markup for a Gii CRUD generated page:

I understand that the current parameters could be passed (to the delete button for example) to allow redirect to the index page and end up on the same view (page X, filtered by field Y and sorted by field Z) as before of clicking the delete button... but I think it's an specific behavior that the developer should be able to choose to use or not.

This behavior could be added as an option:

• boolean $includeRequestParams,
• or boolean|array $requestParamsToInclude (boolean to pass all of them)

at ActionColumn level or at button level (my personal preference).

[vjik]

Currently URL for action buttons don't generate automatically.

Is such generation necessary? If yes, by what logic should it work?

[samdark]

It's about redirect that happens after an action is done, i.e. returning to the same filtered view after deletion is done or editing is done.

1. Go to page 5, filtered by username = X.
2. Delete a user.
3. Redirect to page 5, filtered by username = X happens.

There are edge cases, though, such as deleting a record so the page no longer exists.

[samdark]

I think it can safely be done after initial release.

[vjik]

It can be done something like this.

1. Optionally, add encoded current parameters to URL in actions as separate parameter.
2. Create new class for generate URL to page with GridView, that use encoded paramater from step 1.

[glpzzz]

I think I can do this task.

[samdark]

@glpzzz any luck with it?

[glpzzz]

Not yet. WIP