From 5032f0deca74788dc9c8dd22da4c806d66b76f5d Mon Sep 17 00:00:00 2001 From: Yanfeng Liu Date: Fri, 23 Aug 2024 12:47:49 +0800 Subject: [PATCH] arm/qemu: use WFI to avoid busy loop This adds WFI based up_idle() for arm/qemu to fix busy loop. Signed-off-by: Yanfeng Liu --- arch/arm/Kconfig | 1 + arch/arm/src/qemu/CMakeLists.txt | 3 +- arch/arm/src/qemu/Make.defs | 1 + arch/arm/src/qemu/qemu_idle.c | 61 ++++++++++++++++++++++++++++++++ 4 files changed, 65 insertions(+), 1 deletion(-) create mode 100644 arch/arm/src/qemu/qemu_idle.c diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 25646d13fa5e6..bc3fd6a0664dd 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -657,6 +657,7 @@ config ARCH_CHIP_QEMU_ARM select ARCH_HAVE_PSCI select ARCH_HAVE_POWEROFF select ARCH_HAVE_RESET + select ARCH_IDLE_CUSTOM ---help--- QEMU virt platform (ARMv7a) diff --git a/arch/arm/src/qemu/CMakeLists.txt b/arch/arm/src/qemu/CMakeLists.txt index 09a215885105a..ba28a738508c5 100644 --- a/arch/arm/src/qemu/CMakeLists.txt +++ b/arch/arm/src/qemu/CMakeLists.txt @@ -18,7 +18,8 @@ # # ############################################################################## -set(SRCS qemu_boot.c qemu_serial.c qemu_irq.c qemu_timer.c qemu_memorymap.c) +set(SRCS qemu_boot.c qemu_serial.c qemu_irq.c qemu_timer.c qemu_memorymap.c + qemu_idle.c) if(CONFIG_SMP) list(APPEND SRCS qemu_cpuboot.c) diff --git a/arch/arm/src/qemu/Make.defs b/arch/arm/src/qemu/Make.defs index f51924e3b07bf..02a15047d0193 100644 --- a/arch/arm/src/qemu/Make.defs +++ b/arch/arm/src/qemu/Make.defs @@ -22,6 +22,7 @@ include armv7-a/Make.defs # qemu-specific C source files CHIP_CSRCS = qemu_boot.c qemu_serial.c qemu_irq.c qemu_timer.c qemu_memorymap.c +CHIP_CSRCS += qemu_idle.c ifeq ($(CONFIG_SMP),y) CHIP_CSRCS += qemu_cpuboot.c diff --git a/arch/arm/src/qemu/qemu_idle.c b/arch/arm/src/qemu/qemu_idle.c new file mode 100644 index 0000000000000..1e46a734f753b --- /dev/null +++ b/arch/arm/src/qemu/qemu_idle.c @@ -0,0 +1,61 @@ +/**************************************************************************** + * arch/arm/src/qemu/qemu_idle.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include + +#include +#include "arm_internal.h" + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: up_idle + * + * Description: + * up_idle() is the logic that will be executed when there is no other + * ready-to-run task. This is processor idle time and will continue until + * some interrupt occurs to cause a context switch from the idle task. + * + * Processing in this state may be processor-specific. e.g., this is where + * power management operations might be performed. + * + ****************************************************************************/ + +void up_idle(void) +{ +#if defined(CONFIG_SUPPRESS_INTERRUPTS) || defined(CONFIG_SUPPRESS_TIMER_INTS) + /* If the system is idle and there are no timer interrupts, then process + * "fake" timer interrupts. Hopefully, something will wake up. + */ + + nxsched_process_timer(); +#else + + /* Sleep until an interrupt occurs to save power */ + + asm("WFI"); +#endif +}