Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Pool result is outputted from end to start when read = False #196

Closed
Orangemaple23 opened this issue Aug 5, 2024 · 3 comments
Closed

Comments

@Orangemaple23
Copy link

Hi @yellowbean, thank you for adding in the option of adding in multipools! I noticed that if read=False within the multi pool then the server response is outputted from the last cashflows to the first and not in descending order, whereas with read=True it is outputted in the correct order.

Is this something that could be changed so that the first cashflows are outputted first for each of the pools?

Please find attached a notebook showing this. Thank you!
multi_pool_example.zip

@yellowbean
Copy link
Owner

yellowbean commented Aug 5, 2024

@Orangemaple23

Thanks , I can pin point the issue, should be a quick fix, while, I'll add a unit test to enusre that won't happen somewhere else.

Esti: 1~2 days , in a DEV release, with version 0.28.x

@yellowbean
Copy link
Owner

@Orangemaple23

Fixed with version 0.28.16
#197

The engine was passing wrong order of arguments to pool cashflow
Python wrapper will use date as sort index, that's why absbox is returning correct order.

@Orangemaple23
Copy link
Author

Thank you! Can confirm that it works now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants