New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wal Calculation Fix #152

Closed

yellowbean opened this issue Feb 27, 2024 · 0 comments · Fixed by #154

Owner

yellowbean commented Feb 27, 2024 •

edited

Loading

remove duplication code
There is a new function included : calcWalBond https://github.com/yellowbean/Hastructure/blob/2d4dadf84e935e7e426cb9dbc27980049052225f/src/Liability.hs#L223C1-L223C13

But there is the duplication of WAL calculation:

Hastructure/src/Liability.hs

Line 188 in 2d4dadf

wal = ((foldr

The code above should be replace by the calcWalBond function

calculation of cutoff balance can be optimized:

Hastructure/src/Liability.hs

Line 170 in 2d4dadf

cutoffBalance = case S.getTxnAsOf txns d of

The text was updated successfully, but these errors were encountered:

yellowbean linked a pull request

that will close this issue

Merged

yellowbean closed this as completed in #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment