Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File::open unnecessary check for filename.length #2

Open
YuriL180821 opened this issue May 22, 2024 · 0 comments
Open

File::open unnecessary check for filename.length #2

YuriL180821 opened this issue May 22, 2024 · 0 comments

Comments

@YuriL180821
Copy link
Contributor

Code

if (filename.length() == 0) {
	throw FileException(ErrorMessages::EmptyFilename);
}

is excess. we have if (!mFile.is_open()) check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@YuriL180821