Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore importing Integration Test suite using Strategy test suite in Vaults #25

Open
fubuloubu opened this issue Feb 12, 2021 · 3 comments
Open

Explore importing Integration Test suite using Strategy test suite in Vaults #25

fubuloubu opened this issue Feb 12, 2021 · 3 comments
Labels
p3 fix if time

Comments

@fubuloubu
Copy link
Member

From discussion in #14
@saltyfacu saltyfacu added the p3 fix if time label Feb 15, 2021
@ghost
Copy link

ghost commented Mar 2, 2021

That will probably require to change the test from the yearn vault repo to use the pytest.approx + strategy.estimatedTotalAssets approach.

@fubuloubu
Copy link
Member Author

That will probably require to change the test from the yearn vault repo to use the pytest.approx + strategy.estimatedTotalAssets approach.

Yes true!

@0xkofee
Copy link

0xkofee commented Mar 7, 2022

can this be closed? @fubuloubu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p3 fix if time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@saltyfacu @fubuloubu @0xkofee