Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPCC: Regression in main on 16k wh #10570

Open
naspirato opened this issue Oct 17, 2024 · 5 comments
Open

TPCC: Regression in main on 16k wh #10570

naspirato opened this issue Oct 17, 2024 · 5 comments
Assignees

Comments

@naspirato
Copy link
Collaborator

naspirato commented Oct 17, 2024

https://datalens.yandex/wf5xdbbl923ok?tab=qrg&state=a060a97a500

Monitoring Link Branch Environment Timestamp (Test Run Start) Commit SHA Timestamp (Commit) Transactions/sec Throughput (ops/sec) Throughput (%) Latency (ms)
origin/main default 15.10.2024 23:06:29 b390c9db 15.10.2024 18:24:48 16,000 203,701 99.00 256
origin/main default 15.10.2024 16:35:11 168df93b 15.10.2024 14:15:53 16,000 202,852 98.59 416
origin/main default 15.10.2024 09:52:55 11f9117b 15.10.2024 07:57:34 16,000 203,371 98.84 288
origin/main default 14.10.2024 20:35:26 942b770d 14.10.2024 16:53:57 16,000 204,509 99.39 224
origin/main default 14.10.2024 13:47:30 b4ac18d0 14.10.2024 12:05:43 16,000 204,347 99.31 224
origin/main default 14.10.2024 06:59:31 ddea4fb3 14.10.2024 05:27:38 16,000 204,426 99.35 224

git log --graph --oneline --pretty=format:'%H - %ad %s' 942b770^..11f9117

@naspirato
Copy link
Collaborator Author

naspirato commented Oct 17, 2024

Без волатильных транзацкий регрессия по tmpc 187 939 -> 178 946 = - 4,5%

Branch Environment Timestamp (Test Run Start) Commit SHA Timestamp (Commit) Transactions/sec Throughput (ops/sec) Throughput (%) Latency (ms)
origin/main default_volatile_off 17.10.2024 10:52:51 11f9117b 15.10.2024 07:57:34 16,000 178,946 86.97 5,500
origin/main default_volatile_off 17.10.2024 01:40:53 942b770d 14.10.2024 16:53:57 16,000 187,939 91.34 4,250

@naspirato
Copy link
Collaborator Author

Regression starts in commit 11f9117

@va-kuznecov
Copy link
Member

va-kuznecov commented Oct 17, 2024

possible fix - #10565

@naspirato
Copy link
Collaborator Author

naspirato commented Oct 18, 2024

@va-kuznecov
still same results
https://datalens.yandex/wf5xdbbl923ok?tab=qrg&state=ec22e1fb173
image

origin/main default_volatile_off 18.10.2024 01:44:10 e8cfb02 17.10.2024 19:39:03 16 000 179 625 87,30 5 500

already after fix

git log --graph --oneline --pretty=format:'%H - %ad %s' d4fa83b84d041d1a01390aa880c9ce9aae93d9b5^..e8cfb021cce59392d89126e52e591781e0013b4f
->> * e8cfb021cce59392d89126e52e591781e0013b4f - Thu Oct 17 22:39:03 2024 +0300 [CBO] No join was chosen bug fix (#10576) <--
* 43a091e932037ca9772b028bf9801b4e3f97077e - Thu Oct 17 21:03:42 2024 +0300 Revert "Removed legacy KV API" (#10552)
* 07c567d0879271ac53c1455e7c1d4c525882d461 - Thu Oct 17 21:03:09 2024 +0300 Revert "Make block combine hashed use stream instead of flow (#9979)" (#10575)
* 99a99889ebad8d7db29ab4db7cb2ce75ac15c0d7 - Thu Oct 17 19:02:01 2024 +0200 Public api to return node id in the describe table call (#10571)
* 81a97e1e811fa596a6018aa74ea1640a8c42abe4 - Thu Oct 17 18:12:40 2024 +0200 [refactoring] Do not include executor_thread.h into actor.h (#10562)
* aadf67f0b404ed91cf4f0f4e4c858928fd3bab31 - Thu Oct 17 18:43:09 2024 +0300 Streamlookup special case nulls in keys (#10508)
->> * d4fa83b84d041d1a01390aa880c9ce9aae93d9b5 - Thu Oct 17 17:34:30 2024 +0200 Set SubmitInFlightBytesMax back to 32KiB (#10565) 
* ```

@va-kuznecov
Copy link
Member

revert all noop scheduler related commits - #10600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants