Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove direct grpc type StatusCode from public api #136

Open
rekby opened this issue Mar 13, 2023 · 2 comments
Open

remove direct grpc type StatusCode from public api #136

rekby opened this issue Mar 13, 2023 · 2 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@rekby
Copy link
Member

rekby commented Mar 13, 2023

StatusCode

    pub fn operation_status(&self) -> YdbResult<StatusCode> {
        StatusCode::from_i32(self.operation_status).ok_or_else(|| {
            YdbError::InternalError(format!("unknown status code: {}", self.operation_status))
        })
    }
@rekby rekby added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Mar 13, 2023
@kon3gor
Copy link

kon3gor commented Apr 21, 2023

Hi @rekby I'd like to work on this issue, don't you mind?

@rekby
Copy link
Member Author

rekby commented Apr 23, 2023

@kon3gor , it will great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants