Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SLO tests #122

Open
Tracked by #20
rekby opened this issue Feb 9, 2023 · 1 comment
Open
Tracked by #20

Add SLO tests #122

rekby opened this issue Feb 9, 2023 · 1 comment
Labels
student good issue for student work. Take from few days to 2 weeks. There is a clear solution.

Comments

@rekby
Copy link
Member

rekby commented Feb 9, 2023

after #121
@zeruk
Copy link

zeruk commented Mar 3, 2023

@rekby
CI example is here: https://github.com/ydb-platform/ydb-nodejs-sdk/blob/main/.github/workflows/slo.yml
Workload sample and description is here: https://github.com/ydb-platform/ydb-nodejs-sdk/tree/main/slo-workload
As you can see from the repository, you will need to create a directory for the workload package and provide a Dockerfile inside it.

Important note: Do not run SLO tests in pull requests. You will either have to open secrets for pull requests, or give rights to each contributor (which is not a safe method either). The way I see it, the best option is to run tests on the main branch

@zeruk zeruk mentioned this issue Mar 3, 2023
Closed
7 tasks
@rekby rekby added the student good issue for student work. Take from few days to 2 weeks. There is a clear solution. label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
student good issue for student work. Take from few days to 2 weeks. There is a clear solution.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rekby @zeruk