diff --git a/.changes/unreleased/Changed-20250224-104818.yaml b/.changes/unreleased/Changed-20250224-104818.yaml new file mode 100644 index 00000000..076ebfe4 --- /dev/null +++ b/.changes/unreleased/Changed-20250224-104818.yaml @@ -0,0 +1,3 @@ +kind: Changed +body: 'set updateStrategy: OnDelete for Storage StatefulSet by default' +time: 2025-02-24T10:48:18.815104+08:00 diff --git a/internal/resources/database_statefulset.go b/internal/resources/database_statefulset.go index a27f977b..9c9e9ed3 100644 --- a/internal/resources/database_statefulset.go +++ b/internal/resources/database_statefulset.go @@ -62,7 +62,7 @@ func (b *DatabaseStatefulSetBuilder) Build(obj client.Object) error { if value, ok := b.ObjectMeta.Annotations[api.AnnotationUpdateStrategyOnDelete]; ok && value == api.AnnotationValueTrue { sts.Spec.UpdateStrategy = appsv1.StatefulSetUpdateStrategy{ - Type: "OnDelete", + Type: appsv1.OnDeleteStatefulSetStrategyType, } } diff --git a/internal/resources/storage_statefulset.go b/internal/resources/storage_statefulset.go index 5fb87671..2da17c3b 100644 --- a/internal/resources/storage_statefulset.go +++ b/internal/resources/storage_statefulset.go @@ -72,18 +72,15 @@ func (b *StorageStatefulSetBuilder) Build(obj client.Object) error { labels.StatefulsetComponent: b.Name, }, }, + UpdateStrategy: appsv1.StatefulSetUpdateStrategy{ + Type: appsv1.OnDeleteStatefulSetStrategyType, + }, PodManagementPolicy: appsv1.ParallelPodManagement, RevisionHistoryLimit: ptr.Int32(10), ServiceName: fmt.Sprintf(InterconnectServiceNameFormat, b.Storage.Name), Template: b.buildPodTemplateSpec(), } - if value, ok := b.ObjectMeta.Annotations[api.AnnotationUpdateStrategyOnDelete]; ok && value == api.AnnotationValueTrue { - sts.Spec.UpdateStrategy = appsv1.StatefulSetUpdateStrategy{ - Type: "OnDelete", - } - } - pvcList := make([]corev1.PersistentVolumeClaim, 0, len(b.Spec.DataStore)) for i, pvcSpec := range b.Spec.DataStore { pvcList = append(