Skip to content
This repository has been archived by the owner on Aug 10, 2020. It is now read-only.

Code: add unit tests to aid innovation without regressions #13

Open
nfreear opened this issue Mar 17, 2013 · 2 comments
Open

Code: add unit tests to aid innovation without regressions #13

nfreear opened this issue Mar 17, 2013 · 2 comments
Labels
vanillajs

Comments

@nfreear
Copy link
Contributor

nfreear commented Mar 17, 2013

To implement issue #12 I'll need to re-arrange the vanillajs code somewhat. So I thought this would be a good time to include some unit tests.

I propose using a lightweight framework initially - BusterJS, hosted via CDN.

However, I suggest we make it fully automated in time, perhaps using Grunt, PhantomJS etc. Note, I don't want to make the project top-heavy. The currently Javascripts are lightweight, and good at doing one job. It would be a pity to add lots of supporting files...

Thoughts welcome!
nfreear added a commit to nfreear/accessifyhtml5.js that referenced this issue Mar 17, 2013
@nfreear
Bug yatil#13, Implement lightweight unit tests, initially using Buste…
808adad 
…rJS,

* Before implementing bug yatil#12 - extend AccessifyHTML5 for arbitrary HTML 4,
* Initially vanillajs,
* http://busterjs.org
nfreear added a commit to nfreear/accessifyhtml5.js that referenced this issue Mar 17, 2013
@nfreear
Bug yatil#12, Extending AccessifyHTML5 to add WAI-ARIA roles to HTML 4*
f6732b5 
* That is, roles for arbitrary legacy HTML containing <div> etc,
* AccessifyHTML5(): argument 1 unchanged, argument 2 added,
* Commit adds support for `aria-label` attributes etc,
* Todo: add support for `aria-labelledby`,
* yatil#13, `bjs1` unit test still passes + new `bjs2` - BusterJS.
@nfreear
Copy link
Contributor Author

nfreear commented Mar 18, 2013

Unit test related edits in,

Using asserts.tagName() - buster-assertions

nfreear added a commit to nfreear/accessifyhtml5.js that referenced this issue Mar 18, 2013
@nfreear
Bug yatil#13, Improve commenting and unit tests in bjs[1-2].html - …
745127d 
…Buster.JS

* http://docs.busterjs.org/en/latest/modules/buster-assertions
@nfreear nfreear mentioned this issue Mar 18, 2013
Merged
nfreear added a commit to nfreear/accessifyhtml5.js that referenced this issue Mar 19, 2013
@nfreear
Bug yatil#13, Buster.js unit tests do NOT work on Internet Explorer, so
679125d 
* Add conditional comments so that tests aren't run! (They crash MSIE)
* Add a "Sorry.." message for MSIE
nfreear added a commit to nfreear/accessifyhtml5.js that referenced this issue Mar 19, 2013
@nfreear
Bug yatil#15, Security - filter un-safe attributes and value-types
b684883 
* Add a Regex match against an attribute 'whitelist' - `ATTR_SECURE`
* Add a typeof test for the value
* Add unit tests - issue yatil#13
@nfreear
Copy link
Contributor Author

nfreear commented Mar 19, 2013

To assess the state of Buster.js on Windows/ Internet Explorer (nfreear/accessifyhtml5.js@679125d9e11de668), see

nfreear added a commit to nfreear/accessifyhtml5.js that referenced this issue Mar 20, 2013
@nfreear
Pull yatil#14, Fixed "describeedby" bug, re-minified `accessifyhtml5.…
ed493a9 
…min.js`

* ..And enable switching unit test to `min` JS: `/test/bjs2.html?min=1`
* yatil#13, Added unit test for "describee?dby"
* yatil#12, Used Closure: http://closure-compiler.appspot.com/home
nfreear added a commit to nfreear/accessifyhtml5.js that referenced this issue Mar 24, 2013
@nfreear
Pull yatil#14, fix: buster.testCase and `AccessifyHTML5' calls on Load
df0af03 
* Plus, moved test-utility Javascript to `accessify-qutils.js` - yatil#13
nfreear added a commit to nfreear/accessifyhtml5.js that referenced this issue Mar 26, 2013
@nfreear
Pull yatil#14, Re-minified accessifyhtml5.js Javascript,
d6c1070 
* Bug yatil#13, add unit test for <input type = email > - BusterJS
* Add Github "Fork me" banner in CSS, `yatil/accessifyhtml5.js`
* http://closure-compiler.appspot.com - SIMPLE_OPTIMIZATIONS
@nfreear nfreear mentioned this issue Apr 19, 2014
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
vanillajs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nfreear