-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.2.7 requires latest hatchling #6
Comments
Probably something changed in pypi, but my old pyproject.toml with my old virtualenv (with old hatchling) stopped working (and I upgraded hatchling and maybe changed pyproject.toml to make it work again). Now I recreated that situation, I pinned hatchling to 1.21.1 for test,
I played with I do not understand why/how hatchling adds license-file to metadata out of nowhere.
for setuptools - it was not needed, I just added it because nothing worked so I tried every stupid thing hoping something will finally work. |
Hmm, I never really worked with hatchling. For my personal projects, I just stick to setuptools + I just added The pypi rejection seems to be a well-known problem in hatchling, see for example pypa/hatch#1786 (comment) |
More precisely, the relevant commit is likely pypa/hatch@1867a90 |
Thank you! Just to clarify (maybe you know it) - (latest) hatchling is needed only to build package which would be accepted by pypi. Any random Fedora user do not need hatch/hatchling to use showcert. As I understand, hatch checks I had a slightly different problem with hatch/pypi,
fortunately, I was given a solution to specify proper required version of hatchling in |
Sure but for Fedora packages we have to build from source. Every bit we ship in Fedora must be built on Fedora infrastructure. We must not use any wheels, pyc files, not even metadata in .egg-info. |
In 0.2.7 you started to require hatchling 1.26.3 which was released just a week ago:
showcert/pyproject.toml
Line 3 in 2d98661
Fedora uses modern tools but not that modern: https://src.fedoraproject.org/rpms/python-hatchling
Do you really need 1.26.3 or can we maybe use 1.21 which is the current version for Fedora 41 (and RHEL 9)?
Besides: Are you sure you need both setuptools AND hatchling? Also it would be nice if the license file is declared in
pyproject.toml
as this would declare the license properly in the built RPM (at least with the setuptools backend, not sure about hatchling.The text was updated successfully, but these errors were encountered: