Ui changes for adjusted estimator db model #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it ! |
|
Does it fix #1835 ? Or is it simply moving the problem to backend ? |
grzanka
approved these changes
Dec 10, 2024
grzanka
deleted the
1876-fluka-example-doesnt-produce-results-on-yap-dev
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR needed by yaptide/yaptide#1243
This pull request includes several changes to the
src/WrapperApp/components/Resultsandsrc/services/ShSimulatorService.tsxfiles to improve the handling of estimator names and refactoring of the code. The most important changes include removing the trailing underscore from estimator names, simplifying theResultsPanelcomponent, and refactoring theShSimulatorServiceto remove unused functions.Changes to estimator names:
src/WrapperApp/components/Results/EstimatorsSelect/EstimatorsSelect.tsx: Removed the trailing underscore from theestimatorNamein thegetJobResultcall.src/services/ShSimulatorService.tsx: Removed the trailing underscore from thefirstEstimatorNamein theShSimulationfunction.Simplification of
ResultsPanelcomponent:src/WrapperApp/components/Results/ResultsPanel.tsx: Simplified theuserTabInputFilesEstimatorNamesby removing the slicing operation.Refactoring of
ShSimulatorService:src/services/ShSimulatorService.tsx: Removed therecreateOrderInEstimatorsfunction and updated therecreateRefsInResultsfunction to directly userecreateRefToFilters. [1] [2]