Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency on @ember/string #402

Closed
bjornharrtell opened this issue Sep 16, 2024 · 2 comments
Closed

Missing dependency on @ember/string #402

bjornharrtell opened this issue Sep 16, 2024 · 2 comments

Comments

@bjornharrtell
Copy link
Contributor

bjornharrtell commented Sep 16, 2024

I suspect this is cause of sudden "Could not find module @ember/string imported from ember-modal-dialog/components/modal-dialog", after a transitive dependency upgrade. As of yet unable to find out which transitive dep is causing the break.. but nevertheless, I think it's an error that ember-modal-dialog doesn't declare that it has dependency on @ember/string. Similar problem as emberjs/ember-inflector#501.

@bjornharrtell
Copy link
Contributor Author

I found that the break occurs when upgrading @ember/string from 3.0.0 to 4.0.0.

@lukemelia
Copy link
Contributor

Addressed in #403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants