Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report on ReverseDiffusionPredictor #67

Open
dongli96 opened this issue Oct 29, 2024 · 0 comments
Open

Bug report on ReverseDiffusionPredictor #67

dongli96 opened this issue Oct 29, 2024 · 0 comments

Comments

@dongli96
Copy link

Hello,

In ./sampling.py, line 190, you have a class ReverseDiffusionPredictor:

@register_predictor(name='reverse_diffusion')
class ReverseDiffusionPredictor(Predictor):
  def __init__(self, sde, score_fn, probability_flow=False):
    super().__init__(sde, score_fn, probability_flow)

  def update_fn(self, x, t):
    f, G = self.rsde.discretize(x, t)
    z = torch.randn_like(x)
    x_mean = x - f
    x = x_mean + G[:, None, None, None] * z
    return x, x_mean

in which the method update_fn looks incorrect to me. The item with score seemed to be lacking. Should it be something like x = x_mean + G^2*score + G*z?

I am looking forward to hearing from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant