We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yammer::ApiResponse#success? is not consistent when reporting on the success of the request. Consider the following:
Yammer::ApiResponse#success?
client = Yammer::Client.new(access_token: access_token) # => #<Yammer::Client:0x007f968faecd10 ...> current_user = client.current_user # => #<Yammer::ApiResponse:0x007f968fc371e8 @body="...", @code=200, ...> current_user.class # => Yammer::ApiResponse current_user.code # => 200 current_user.success? # => true activity_response = client.create_activity(activity) # => #<Yammer::ApiResponse:0x007f968ff41460 @body="...", @code=202, ...> activity_response.class # => Yammer::ApiResponse activity_response.code # => 202 activity_response.success? # => false
I would expect that any response in the 2xx range would report success? as true
success?
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Yammer::ApiResponse#success?
is not consistent when reporting on the success of the request. Consider the following:I would expect that any response in the 2xx range would report
success?
as trueThe text was updated successfully, but these errors were encountered: