Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work on React 16.x #14

Open
ziaulrehman40 opened this issue Aug 26, 2019 · 3 comments
Open

Doesn't work on React 16.x #14

ziaulrehman40 opened this issue Aug 26, 2019 · 3 comments

Comments

@ziaulrehman40
Copy link


TypeError: Cannot read property 'func' of undefined
../../node_modules/react-native-inviewport/index.js
node_modules/react-native-inviewport/index.js:11
   8 | displayName: 'InViewPort',
   9 | mixins: [NativeMethodsMixin],
  10 | propTypes: {
> 11 |   onChange: React.PropTypes.func.isRequired,
     | ^  12 |   active: React.PropTypes.bool,
  13 |   delay: React.PropTypes.number
  14 | },
View compiled

@Base29
Copy link

Base29 commented Sep 26, 2019

@ziaulrehman40 ... getting the same error ... were you able to run this plugin ?

@ziaulrehman40
Copy link
Author

@Base29 No, i didn't spent much time but you can explore the existing forks like this one: dabbott/react-native-inviewport@master...pepe-ves:master

You may need to re-fork and rebase it properly though, or make your own fork and do similar changes.

Issue is clearly because proptypes were removed form core react

@Base29
Copy link

Base29 commented Sep 26, 2019

Thanks @ziaulrehman40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants