Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript d.ts file #1193

Open
orhanveli opened this issue Aug 26, 2016 · 2 comments · May be fixed by #1510
Open

Typescript d.ts file #1193

orhanveli opened this issue Aug 26, 2016 · 2 comments · May be fixed by #1510
Assignees
@stefanpejcic
Labels
enhancement question

Comments

@orhanveli
Copy link
Contributor

orhanveli commented Aug 26, 2016 •
edited
Loading

Hello everyone

It will be great if there's a d.ts definition for medium-editor to help typescript development.

I started a repo and create a d.ts file. But I don't have enough know-how about d.ts files.

Is there a someone to contribute?

https://github.com/orhanveli/medium-editor.d.ts
@j0k3r j0k3r added the question label Aug 26, 2016
@johnbwoodruff
Copy link

@orhanveli rather than hosting it in your own repo you should contribute a definition file to DefinitelyTyped. If there isn't a first-party solution from the library, that is the best place to contribute to.

@jamespacileo
Copy link

@orhanveli the DefinitelyTyped version is missing some important things eg. Extension interface.

It would benefit a lot from a PR using your work.

Alternatively, if I'm not mistaken, TS 2.0+ now supports declaration files included in the original JS project. So it might worth thinking about including such work in the repo.

@ashinzekene ashinzekene linked a pull request Jun 27, 2019 that will close this issue
Open
@stefanpejcic stefanpejcic self-assigned this Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanpejcic stefanpejcic

Labels
enhancement question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Declaration file ashinzekene/medium-editor
6 participants
@j0k3r @orhanveli @jamespacileo @nmielnik @johnbwoodruff @stefanpejcic