Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Minor) Comment of unit of dilution of precision. It should be unitless #88

Closed
rotorman opened this issue Jan 18, 2021 · 2 comments
Closed

(Minor) Comment of unit of dilution of precision. It should be unitless #88

rotorman opened this issue Jan 18, 2021 · 2 comments

Comments

@rotorman
Copy link

Minor problem, but nevertheless it would be nice to have it correct - please check the comment on this line, "dm" seems wrong, as (horizontal) dilution of precision should be unitless:

FrskyTelemetryScript/HORUS/SOURCES/SRC/WIDGETS/Yaapu/main.lua

Line 857 in 82b2245

telemetry.gpsHdopC = bit32.extract(VALUE,7,7) * (10^bit32.extract(VALUE,6,1)) -- dm

@yaapu
Copy link
Owner

yaapu commented Jan 20, 2021

agree, no unit on diluition, thanks

rotorman added a commit to rotorman/FrskyTelemetryScript that referenced this issue Jan 29, 2021
@rotorman
Update main.lua
601ed07 
Removed misleading dilution of precision unit (it's unitless) Issue yaapu#88
@rotorman
Copy link
Author

Fixed in a PR #90 that I created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rotorman @yaapu