Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spider_scheduler and spider_worker don't print CLI usage info #51

Open
kirkrodrigues opened this issue Jan 14, 2025 · 0 comments · May be fixed by #56
Open

spider_scheduler and spider_worker don't print CLI usage info #51

kirkrodrigues opened this issue Jan 14, 2025 · 0 comments · May be fixed by #56
Assignees
Labels
bug Something isn't working

Comments

@kirkrodrigues
Copy link
Member

Bug

Usually, executing a CLI command without arguments or with the --help flag will print usage instructions. This is not the case for spider_scheduler and spider_worker meaning users have to either read the docs or the code to figure out how to use the tools appropriately.

In addition, any unknown arguments or missing values results in an uncaught exception.

We're already using boost::program_options, so we should improve the code to utilize its ability to handle the --help flag and catch parsing exceptions appropriately.

Spider version

e7f7c48

Environment

Ubuntu 24.04

Reproduction steps

# No args
./spider_scheduler
./spider_worker

# Help flag
./spider_scheduler --help
./spider_worker --help

# Argument without value
./spider_scheduler --port
./spider_worker --port
@kirkrodrigues kirkrodrigues added the bug Something isn't working label Jan 14, 2025
@sitaowang1998 sitaowang1998 linked a pull request Jan 15, 2025 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants