Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLP package launching to PR check workflow #694

Open
coderabbitai bot opened this issue Jan 24, 2025 · 1 comment
Open

Add CLP package launching to PR check workflow #694

coderabbitai bot opened this issue Jan 24, 2025 · 1 comment

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 24, 2025

Background

Currently, CLP package launch issues (like the Python compatibility issue in #693) are only discovered after merging changes. Developers usually test on a single platform, such as Ubuntu Focal OR Ubuntu Jammy, and such compatibility issues are not easily discovered unless tests are performed on all platforms. Adding a package launch test to the PR check workflow would help catch these issues earlier in the development cycle.

Feature Request

Add a step to the PR check workflow that:

  1. Builds the CLP package
  2. Attempts to launch it in an environment similar to production
  3. Verifies the launch was successful

This would help catch issues like:

  • Python compatibility issues
  • Missing dependencies
  • Configuration problems
  • Initialization failures

References

/cc @junhaoliao

@junhaoliao
Copy link
Member

Alternatively, for the issue in #693 specifically, a linter rule can be added to disallow syntaxes that are only available in newer Python versions, if such rules exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant