-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TODO comments throughout the solution #23
Comments
@LSViana We have this TODO in the code:
|
@SebastianStehle I think we'll have some solutions if we ever look into that in detail but I didn't do it yet. Given that, I'd just leave it there. It's not harmful and informs other developers who read the same code which is a positive detail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This list is not final and will be accumulated as items are solved:
OutputNative
size with pointer size inMapEntryNative
*Native
counterpart for event classes that don't need itXmlElement.Observe()
that weren't using a root-levelXmlElement
but should beXmlElement.Unobserve()
that weren't using a root-levelXmlElement
but should beXmlElement.Parent()
that weren't returning the correct valueXmlElement.String()
that weren't testing for childXmlText
nodes but should beTransaction.Dispose()
Output.Object
Map.Length()
TextChannel
Doc.Guid
that will not be fixed because the GUID format isn't compatible with C#InputNative
because the size of the data can't be reduced or data will be lostOutput
to supportnull
pointernew Output()
to useReferenceAccessor.Access(Output)
NotImplemented
withNotSupported
exception on theEventBranch
constructor since all cases are now covered[Ignore]
because they were waiting for implementationsIEnumerator<T>.Reset()
on the following classes:ArrayEnumerator
MapEnumerator
XmlAttributeEnumerator
XmlTreeWalkerEnumerator
XmlElement
with anXmlFragment
before returning the value.XmlText
with anXmlFragment
before returning the value.EventSubscription
withUnsubscribe()
.The text was updated successfully, but these errors were encountered: