feat: continue node binding #43
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkskygit
force-pushed
the
darksky/continue-node-binding
branch
from
ba46789
to
b60c673
Compare
Benchmark for LinuxClick to view benchmark
Benchmark for WindowsClick to view benchmark
|
Benchmark for LinuxClick to view benchmark
Benchmark for WindowsClick to view benchmark
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Benchmark for LinuxClick to view benchmark
Benchmark for WindowsClick to view benchmark
|
darkskygit
force-pushed
the
darksky/continue-node-binding
branch
2 times, most recently
from
a288b39
to
8516718
Compare
darkskygit
force-pushed
the
darksky/continue-node-binding
branch
from
8516718
to
e95bef9
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
===========================================
+ Coverage 37.69% 86.26% +48.57%
===========================================
Files 1 1
Lines 260 386 +126
Branches 0 31 +31
===========================================
+ Hits 98 333 +235
+ Misses 162 53 -109
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Benchmark for LinuxClick to view benchmark
Benchmark for WindowsClick to view benchmark
|
| { | ||
| let ret = f(self.doc.clone()); | ||
| for (k, v) in self.doc.get_changed() { | ||
| self.changed.entry(k).or_insert_with(Vec::new).extend(v.iter().cloned()); |
Check failure
Code scanning / clippy
use of or_insert_with to construct default value Error documentation
Comment on lines
+56
to
+58
| let Some(batch) = doc.batch.get_mut() else { | ||
| return None; | ||
| }; |
Check failure
Code scanning / clippy
this let...else may be rewritten with the ? operator Error documentation
| @@ -199,6 +198,17 @@ | |||
| } | |||
| } | |||
|
|
|||
| pub fn get_changed(&self) -> ChangedTypeRefs { | |||
Check failure
Code scanning / clippy
type doc::types::YTypeRef is more private than the item doc::document::Doc::get_changed Error documentation
| @@ -758,6 +779,24 @@ | |||
| Ok(update) | |||
| } | |||
|
|
|||
| fn mark_changed(changed: &mut ChangedTypeRefs, parent: YTypeRef, parent_sub: Option<SmolStr>) { | |||
| if parent.inner.is_some() { | |||
| let vec = changed.entry(parent).or_insert_with(Vec::new); | |||
Check failure
Code scanning / clippy
use of or_insert_with to construct default value Error documentation
| } | ||
| } | ||
|
|
||
| pub fn reset_changed(&mut self) { |
Check failure
Code scanning / clippy
method reset_changed is never used Error documentation
Benchmark for LinuxClick to view benchmark
Benchmark for WindowsClick to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.