From 49ef9086ce614c89b947ce6b498f0de671ef671e Mon Sep 17 00:00:00 2001 From: Jon Burdo Date: Tue, 11 Jul 2023 15:46:56 -0400 Subject: [PATCH 1/2] Add missing Array attributes Array previously threw a NotImplementedError for the python_type attribute and returned True instead of False for hashable. --- clickhouse_sqlalchemy/types/common.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/clickhouse_sqlalchemy/types/common.py b/clickhouse_sqlalchemy/types/common.py index d5659f7a..84cd78ff 100644 --- a/clickhouse_sqlalchemy/types/common.py +++ b/clickhouse_sqlalchemy/types/common.py @@ -30,11 +30,17 @@ class Boolean(types.Boolean, ClickHouseTypeEngine): class Array(ClickHouseTypeEngine): __visit_name__ = 'array' + hashable = False + def __init__(self, item_type): self.item_type = item_type self.item_type_impl = to_instance(item_type) super(Array, self).__init__() + @property + def python_type(self): + return list + def literal_processor(self, dialect): item_processor = self.item_type_impl.literal_processor(dialect) From 2aba46db7a52cb71766930f66c20ca484597a277 Mon Sep 17 00:00:00 2001 From: Marcel Jackwerth Date: Wed, 19 Jul 2023 09:03:44 +0200 Subject: [PATCH 2/2] Remove greenlet dependency The `greenlet>=2.0.1` requirement is forced on all projects importing this package, but it's actually not imported (except from tests for which it already is listed in `testsrequire.py`). --- setup.py | 1 - 1 file changed, 1 deletion(-) diff --git a/setup.py b/setup.py index 10352d6c..754b9035 100644 --- a/setup.py +++ b/setup.py @@ -95,7 +95,6 @@ def read_version(): python_requires='>=3.7, <4', install_requires=[ 'sqlalchemy>=1.4.24,<1.5', - 'greenlet>=2.0.1', 'requests', 'clickhouse-driver>=0.1.2', 'asynch>=0.2.2',