Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Play nice with Nelmio/ApiDocBundle #20

Open
jaymecd opened this issue Jun 14, 2017 · 0 comments
Open

Play nice with Nelmio/ApiDocBundle #20

jaymecd opened this issue Jun 14, 2017 · 0 comments
Labels
bug

Comments

@jaymecd
Copy link

jaymecd commented Jun 14, 2017

Affected versions: 1.x & 2.x

ApiDocBundle (2.13.2) embeds full jQuery lib as js payload directly into the <head> section.
This JS code contains following:

...
(f.support.boxModel?"<!doctype html>":"")+"<html><body>"),cl.close()
...

So GoogleTagManagerListener class (1.0.5 / 2.1.0) do not respect that and inject GTM into JS code, which is not real <body>.

Solution is to update regex from '/<body\b[^>]*>/' to '/<\/head>\s*<body\b[^>]*>/'.

Unfortunately could not provide PR right now, maybe later this week, if it won't be fixed earlier.
@xyNNN xyNNN added the bug label Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaymecd @xyNNN