Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users should not have to reconnect to XWiki for groups to be updated after you reset the cache #13

Open
iuliabalan opened this issue May 30, 2019 · 0 comments

Comments

@iuliabalan
Copy link

AFAIU currently "group cache expiration" is not used in the AD app and for this to work https://jira.xwiki.org/browse/LDAP-72 will be fixed.
However, when there is a mapping defined between AD groups and XWiki groups, the XWiki groups should be updated after the cache reset (without the users having to log out and log in again to XWiki)
Tested behavior on a client with XWiki version 10.8.1 and AD app version 1.6

  • added test user to the AD group (note this groups had mapping defined with an XWiki group)
  • the test user reconnected to XWiki and the corresponding group from XWiki did not update (the user was not added)
  • user "Reset cache group" button and checked again: the corresponding group from XWiki still did not update (the user was not added)
  • the test user logged out and logged in to XWiki and as a result: the corresponding group from XWiki was correctly updated to include as well our test user.
    The same steps were done for removing a user from the AD group and the user had to reconnect after the cache reset.
    This raises a security issue as users may still have rights on wiki/pages until they log out.
    LDAP-72 mentions "update the group cache expiration value without restarting the wiki" so the issue remains if the user still has to log out and log in to XWiki so that group mapping is applied
    Example: in our case, the client had group cache expiration value defined in AD application to 10 seconds, so once LDAP-72 is fixed and this value can be used, why would the user still have to reconnect?
@acotiuga acotiuga added this to the 1.7 milestone Aug 31, 2019
@acotiuga acotiuga self-assigned this Sep 17, 2019
@acotiuga acotiuga removed this from the 1.7 milestone Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants