Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Attaching Docker Volumes #150

Open
OmanDominik opened this issue Dec 4, 2024 · 3 comments
Open

Add Support for Attaching Docker Volumes #150

OmanDominik opened this issue Dec 4, 2024 · 3 comments

Comments

@OmanDominik
Copy link

Proposed Feature:
Introduce a python.docker.volumes configuration option to allow users to specify volumes in the form of mappings, e.g., host_path:container_path. For example:

python {
docker {
image = "python:3.9"
volumes = ["/path/on/host:/path/in/container", "/another/host/path:/another/container/path"]
}
}

@xvik
Copy link
Owner

xvik commented Dec 4, 2024

I will add this option as soon as I'll have time (but can't promise too soon).
Can't suggest a workaround, need time to look deeper (can't right now)

Ideally, there shuld be some extra docker arguments option to be able to specify any additional docker parameters (and workaround situations like this when no direct support available).

@OmanDominik
Copy link
Author

OmanDominik commented Dec 4, 2024

I will add this option as soon as I'll have time (but can't promise too soon).

Can't suggest a workaround, need time to look deeper (can't right now)

Ideally, there shuld be some extra docker arguments option to be able to specify any additional docker parameters (and workaround situations like this when no direct support available).

Happy to hear that, can I possibly prepare a PR? Also cant promise too much as I did not develop any plugin so far, but I can give it a try.

@xvik
Copy link
Owner

xvik commented Dec 4, 2024

You can try - it would be a good exercise in any case. But it will take time to proceed even with PR
(in order to release I need not only to add "volumes" property, but read docker docs first to be sure to cover all potential needs, imagine possible use-cases and write tests to cover them; and ofc. update docs - it all will take time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants