You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The fs_api layer must allign with rust standard library.
std::fs::read_dir only iterates over children. Ours should do the same.
Changes are needed for:
encryptedFs function,
tests for encryptedFs and for Path
docs for Path method
The text was updated successfully, but these errors were encountered:
Hey! I was trying out both on my system. I see Directory Entry for Encrypted::fs and DirEntry for rust std::fs. What do you mean by align our api to iterate only over children? Can you explain with below example?
Hey! I was trying out both on my system. I see Directory Entry for Encrypted::fs and DirEntry for rust fs. What do you mean by align our api to iterate only over children? Can you explain with below example?
When running std::fs::read_dir, (I'm testing it on linux and windows) it will only iterate over children and ignore . and ...
read_dir and read_dir_plus in our EncryptedFs current include . and ...
In your example, ino: 1 is root (or parent) dir - .. When running fs.read_dir(1), it should show only the RegularFile.
This is not exactly a bug however, our own fs_api::fs::read_dir will be using these functions and we want it to be 100% interchangeable with std library.
Are you getting a different behaviour out of std::fs::read_dir?
The fs_api layer must allign with rust standard library.
std::fs::read_dir only iterates over children. Ours should do the same.
Changes are needed for:
The text was updated successfully, but these errors were encountered: