From 9a41eded2d5c7998eb09501225ea6865507f96e4 Mon Sep 17 00:00:00 2001
From: bdovaz <borja.dominguez@hotmail.com>
Date: Sat, 29 Jul 2023 17:06:49 +0200
Subject: [PATCH] chore: house keeping

---
 .editorconfig                                 |  5 +-
 .../UnityNuGet.Server.csproj                  | 53 +++++++++--------
 src/UnityNuGet.Tests/.editorconfig            |  4 ++
 src/UnityNuGet.Tests/UnityNuGet.Tests.csproj  | 29 ++++-----
 src/UnityNuGet/UnityMeta.cs                   |  6 +-
 src/UnityNuGet/UnityNuGet.csproj              | 59 ++++++++++---------
 6 files changed, 83 insertions(+), 73 deletions(-)
 create mode 100644 src/UnityNuGet.Tests/.editorconfig

diff --git a/.editorconfig b/.editorconfig
index 51b8bb31..bef1b331 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -2,4 +2,7 @@
 root = true
 
 [*.{cs,json,txt,yml}]
-end_of_line = lf
\ No newline at end of file
+end_of_line = lf
+
+[*.{csproj}]
+indent_size = 2
\ No newline at end of file
diff --git a/src/UnityNuGet.Server/UnityNuGet.Server.csproj b/src/UnityNuGet.Server/UnityNuGet.Server.csproj
index 1756326f..c2b641e2 100644
--- a/src/UnityNuGet.Server/UnityNuGet.Server.csproj
+++ b/src/UnityNuGet.Server/UnityNuGet.Server.csproj
@@ -1,33 +1,34 @@
-<Project Sdk="Microsoft.NET.Sdk.Web">
+<Project Sdk="Microsoft.NET.Sdk.Web">
 
-    <PropertyGroup>
-        <TargetFramework>net7.0</TargetFramework>
-        <Nullable>enable</Nullable>
-        <ApplicationInsightsResourceId>/subscriptions/b6745039-70e7-4641-994b-5457cb220e2a/resourcegroups/Default-ApplicationInsights-EastUS/providers/microsoft.insights/components/unitynuget-registry</ApplicationInsightsResourceId>
-        <ApplicationInsightsAnnotationResourceId>/subscriptions/b6745039-70e7-4641-994b-5457cb220e2a/resourcegroups/Default-ApplicationInsights-EastUS/providers/microsoft.insights/components/unitynuget-registry</ApplicationInsightsAnnotationResourceId>
-        <UserSecretsId>1be0a769-8d75-4a27-99e0-128afcc0ffee</UserSecretsId>
-    </PropertyGroup>
+  <PropertyGroup>
+    <TargetFramework>net7.0</TargetFramework>
+    <Nullable>enable</Nullable>
+    <ApplicationInsightsResourceId>/subscriptions/b6745039-70e7-4641-994b-5457cb220e2a/resourcegroups/Default-ApplicationInsights-EastUS/providers/microsoft.insights/components/unitynuget-registry</ApplicationInsightsResourceId>
+    <ApplicationInsightsAnnotationResourceId>/subscriptions/b6745039-70e7-4641-994b-5457cb220e2a/resourcegroups/Default-ApplicationInsights-EastUS/providers/microsoft.insights/components/unitynuget-registry</ApplicationInsightsAnnotationResourceId>
+    <UserSecretsId>1be0a769-8d75-4a27-99e0-128afcc0ffee</UserSecretsId>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+  </PropertyGroup>
 
-    <PropertyGroup>
-        <DockerfileContext>.</DockerfileContext>
-        <DockerfileFile>..\..\Dockerfile</DockerfileFile>
-        <DockerDefaultTargetOS>Linux</DockerDefaultTargetOS>
-    </PropertyGroup>
+  <PropertyGroup>
+    <DockerfileContext>.</DockerfileContext>
+    <DockerfileFile>..\..\Dockerfile</DockerfileFile>
+    <DockerDefaultTargetOS>Linux</DockerDefaultTargetOS>
+  </PropertyGroup>
 
-    <ItemGroup>
-        <PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" Version="2.21.0" />
-        <PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="7.0.9" />
-        <PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="7.0.0" />
-        <PackageReference Include="Microsoft.Extensions.Options.DataAnnotations" Version="7.0.0" />
-        <PackageReference Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.18.1" />
-    </ItemGroup>
+  <ItemGroup>
+    <PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" Version="2.21.0" />
+    <PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="7.0.9" />
+    <PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="7.0.0" />
+    <PackageReference Include="Microsoft.Extensions.Options.DataAnnotations" Version="7.0.0" />
+    <PackageReference Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.18.1" />
+  </ItemGroup>
 
-    <ItemGroup>
-        <ProjectReference Include="..\UnityNuGet\UnityNuGet.csproj" />
-    </ItemGroup>
+  <ItemGroup>
+    <ProjectReference Include="..\UnityNuGet\UnityNuGet.csproj" />
+  </ItemGroup>
 
-    <ItemGroup>
-        <WCFMetadata Include="Connected Services" />
-    </ItemGroup>
+  <ItemGroup>
+    <WCFMetadata Include="Connected Services" />
+  </ItemGroup>
 
 </Project>
diff --git a/src/UnityNuGet.Tests/.editorconfig b/src/UnityNuGet.Tests/.editorconfig
new file mode 100644
index 00000000..97faf8d9
--- /dev/null
+++ b/src/UnityNuGet.Tests/.editorconfig
@@ -0,0 +1,4 @@
+[*.cs]
+
+# SYSLIB1045: Convert to 'GeneratedRegexAttribute'.
+dotnet_diagnostic.SYSLIB1045.severity = none
diff --git a/src/UnityNuGet.Tests/UnityNuGet.Tests.csproj b/src/UnityNuGet.Tests/UnityNuGet.Tests.csproj
index 778d4737..9e05d850 100644
--- a/src/UnityNuGet.Tests/UnityNuGet.Tests.csproj
+++ b/src/UnityNuGet.Tests/UnityNuGet.Tests.csproj
@@ -1,19 +1,20 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
-    <PropertyGroup>
-        <TargetFramework>net7.0</TargetFramework>
-        <IsPackable>false</IsPackable>
-        <IsPublishable>false</IsPublishable>
-    </PropertyGroup>
+  <PropertyGroup>
+    <TargetFramework>net7.0</TargetFramework>
+    <IsPackable>false</IsPackable>
+    <IsPublishable>false</IsPublishable>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+  </PropertyGroup>
 
-    <ItemGroup>
-        <PackageReference Include="nunit" Version="3.13.3" />
-        <PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
-        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.3" />
-    </ItemGroup>
+  <ItemGroup>
+    <PackageReference Include="nunit" Version="3.13.3" />
+    <PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.3" />
+  </ItemGroup>
 
-    <ItemGroup>
-      <ProjectReference Include="..\UnityNuGet\UnityNuGet.csproj" />
-    </ItemGroup>
+  <ItemGroup>
+    <ProjectReference Include="..\UnityNuGet\UnityNuGet.csproj" />
+  </ItemGroup>
 
 </Project>
\ No newline at end of file
diff --git a/src/UnityNuGet/UnityMeta.cs b/src/UnityNuGet/UnityMeta.cs
index 2b564f9d..f43a3429 100644
--- a/src/UnityNuGet/UnityMeta.cs
+++ b/src/UnityNuGet/UnityMeta.cs
@@ -16,11 +16,11 @@ internal static class UnityMeta
             {
                 case ".pdb":
                     break;
-
+                case ".asmdef":
                 case ".json":
-                case ".xml":
-                case ".txt":
                 case ".md":
+                case ".txt":
+                case ".xml":
                     return GetMetaForText(guid);
             }
 
diff --git a/src/UnityNuGet/UnityNuGet.csproj b/src/UnityNuGet/UnityNuGet.csproj
index c24eba35..4a432f9a 100644
--- a/src/UnityNuGet/UnityNuGet.csproj
+++ b/src/UnityNuGet/UnityNuGet.csproj
@@ -1,35 +1,36 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
-    <PropertyGroup>
-        <TargetFramework>net7.0</TargetFramework>
-        <Nullable>enable</Nullable>
-        <Version>0.14.0</Version>
-        <LangVersion>9.0</LangVersion>
-    </PropertyGroup>
+  <PropertyGroup>
+    <TargetFramework>net7.0</TargetFramework>
+    <Nullable>enable</Nullable>
+    <Version>0.14.0</Version>
+    <LangVersion>9.0</LangVersion>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+  </PropertyGroup>
 
-    <ItemGroup>
-      <None Remove="registry.json" />
-    </ItemGroup>
+  <ItemGroup>
+    <None Remove="registry.json" />
+  </ItemGroup>
 
-    <ItemGroup>
-      <Content Include="..\..\registry.json" Link="registry.json">
-        <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
-      </Content>
-    </ItemGroup>
-    
-    <ItemGroup>
-        <FrameworkReference Include="Microsoft.AspNetCore.App" />
-    </ItemGroup>
+  <ItemGroup>
+    <Content Include="..\..\registry.json" Link="registry.json">
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+    </Content>
+  </ItemGroup>
 
-    <ItemGroup>
-      <PackageReference Include="Microsoft.Extensions.Options" Version="7.0.1" />
-      <PackageReference Include="NuGet.PackageManagement" Version="6.6.1" />
-      <PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="7.0.0" /> 
-      <PackageReference Include="NUglify" Version="1.20.7" /> 
-      <PackageReference Include="Scriban" Version="5.7.0" /> 
-      <PackageReference Include="SharpZipLib" Version="1.4.2" /> 
-      <PackageReference Include="System.ComponentModel.Annotations" Version="5.0.0" /> 
-      <PackageReference Include="System.Linq.Async" Version="6.0.1" /> 
-    </ItemGroup>
+  <ItemGroup>
+    <FrameworkReference Include="Microsoft.AspNetCore.App" />
+  </ItemGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Microsoft.Extensions.Options" Version="7.0.1" />
+    <PackageReference Include="NuGet.PackageManagement" Version="6.6.1" />
+    <PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="7.0.0" />
+    <PackageReference Include="NUglify" Version="1.20.7" />
+    <PackageReference Include="Scriban" Version="5.7.0" />
+    <PackageReference Include="SharpZipLib" Version="1.4.2" />
+    <PackageReference Include="System.ComponentModel.Annotations" Version="5.0.0" />
+    <PackageReference Include="System.Linq.Async" Version="6.0.1" />
+  </ItemGroup>
 
 </Project>