Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: Loosen Key Package Upload Validation #399

Open
6 of 10 tasks
neekolas opened this issue Aug 14, 2024 · 0 comments
Open
6 of 10 tasks

Tracking: Loosen Key Package Upload Validation #399

neekolas opened this issue Aug 14, 2024 · 0 comments
Assignees

Comments

@neekolas
Copy link
Collaborator

neekolas commented Aug 14, 2024

The goal of this project is to allow clients to upload key packages before publishing identity updates. While we are rolling out these changes, we can do a bit of cleanup of some of the legacy APIs that predate the identity work.

Because of some frontend->backend dependencies, we'll need to roll this out in at least two phases.

Phase 1

Tasks

Phase 2

Tasks

@neekolas neekolas self-assigned this Aug 14, 2024
neekolas added a commit to xmtp/libxmtp that referenced this issue Aug 15, 2024
### TL;DR
Implements parts of xmtp/xmtp-node-go#399

- Uses `UploadKeyPackage` instead of `RegisterInstallation` so we can deprecate the register installation endpoint
- Uploads key package _before_ publishing the identity updates for new installations. This ensures that any installation seen in an identity update must have a matching key package.
- No longer checks the lifetime of key packages when verifying

## AI Assisted Summary

### What changed?

- Removed expiration checks and set expiration to 0 in MLS validation service
- Updated the client registration process to register identity before applying signature request
- Renamed `register_installation` to `upload_key_package` in API client calls
- Removed lifetime validity checks from key package verification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant