Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Bubble up specific API error codes to the application developer #221

Closed
neekolas opened this issue Jan 24, 2024 · 0 comments · Fixed by #240
Closed

Feature request: Bubble up specific API error codes to the application developer #221

neekolas opened this issue Jan 24, 2024 · 0 comments · Fixed by #240
Labels
enhancement New feature or request

Comments

@neekolas
Copy link
Contributor

Is your feature request related to a problem?

When a developer hits an error in our API, they get back a very generic error (Error: The operation couldn't be completed. (XMTP.ApiClientError error 1.). It would be helpful to know what type of error the node returned. Especially 429 errors from being rate limited

Describe the solution to the problem

Modify the bindings in libxmtp to return more specific errors. Possibly modify the grpc_api_client to add more detail if needed. Then pass that along to the caller in xmtp-ios.

Describe the uses cases for the feature

Detecting when you have been rate limited to back off from requests.

Additional details

No response
@neekolas neekolas added the enhancement New feature or request label Jan 24, 2024
@nakajima nakajima mentioned this issue Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve error messages xmtp/xmtp-ios
1 participant
@neekolas