Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable QSPI RTOS driver test #142

Closed
GitJRS opened this issue Apr 6, 2023 · 2 comments · Fixed by #172
Closed

Re-enable QSPI RTOS driver test #142

GitJRS opened this issue Apr 6, 2023 · 2 comments · Fixed by #172
Assignees
Labels
size:S small type:testing actual testing or developing test stuff

Comments

@GitJRS
Copy link
Contributor

GitJRS commented Apr 6, 2023

There is a fix in progress which addresses a flash issue with 2v0 boards. Once that is merged, the test/rtos-drivers/hil qspi test should be re-enabled in CI.

@GitJRS GitJRS self-assigned this Apr 6, 2023
@GitJRS
Copy link
Contributor Author

GitJRS commented Apr 6, 2023

blocked by #46

@keithm-xmos keithm-xmos added size:S small type:testing actual testing or developing test stuff labels Apr 11, 2023
@keithm-xmos keithm-xmos changed the title Re-enable qspi driver test Re-enable QSPI RTOS driver test Apr 11, 2023
@xmos-jmccarthy
Copy link
Contributor

The flash test is currently broken.

It appears that since the lib_qspi_fast_read change that the qspi test was silent failing. There are 2 reasons for this, firstly there is no pytest checker in hil_add to verify that QSPI passed, hiding that it has been failing. Second, the flashing of the calibration pattern is missing in the CI test portion.

For #157 the qspi test has been temporarily disabled for the CI. This PR was verified locally.

Please reenable:

set(QSPI_FLASH_FAST_READ_TEST 0)

and update accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S small type:testing actual testing or developing test stuff
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants