-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility CM 13 #8
Comments
@f4stb00t Sorry for late reply. You are lucky that it didn't work, CM13 broke I am looking into solution, problem is that some people are reporting similar problems with stock Android 6, but stock AOSP didn't make those changes to |
@f4stb00t New version of SnooperStopper is compatible with bot stock Android 6 and CyanogenMod 13 (I have tested it on Nexus 5). |
This does not work with a OnePlus one on "stock" CM 13 Perhaps more work may be required The warning message did display about it not working properly, and to gain a root shell to use That prompted me to follow the advice here: nelenkov/cryptfs-password-manager#14 (comment) Which boiled down to using this: And that worked, I was able to reboot and decrypt with my actual password, and my lockscreen password was also still usable. |
@xenithorb SnooperStopper is now using |
I assure you I'm using CM13 nightly
The version of SnooperStopper is 1.3 from F-Droid. I do not have google play, sorry. |
In attempting to try it again, it also thinks my current password, that I know works, is incorrect "Invalid password" I'm going to attempt next to change the password to something simple and try again |
@xenithorb version 1.3 from F-Droid should be OK. This is strange, it should be detected all right (on Nexus 5 it did work without problems, I can't see what is different in this case). Can you show me output of |
Ok, so a few things:
So it would appear that there is an issue with PIN -> Password using SnooperStopper |
Just to clarify since I can be wordy sometimes there appear to be two issues present:
|
Hmm. Weirder result than I thought: From Thus, it seems as though it is setting it properly but displaying the error message still. That was not something I tested for the first time |
For issue 1. it had to do with spaces. I first tested string length and that didn't seem to cause a problem. Once I added a space it failed. I then confirmed by making the password literally 'a b' and it told me it was invalid inside the app (while working fine on the commandline) Quoting or word-splitting issues? To consolidate the issues again:
|
Do you have some time? I will compile debug build with small change in passing of passphrase to |
Sure. Do you have a list of things to grep for like App name, etc, will that be sufficient? I have various things running in the background and I'd rather not leak sensitive information since this is not a dev-only phone but my daily driver. If you're happy with just grepping that app name that makes things a lot easier |
Ok, here it is. Please beware that it is DEBUG build and this will log your password in logcat! Use it only for debugging purposes. EDIT: It is signed by different (debug) key, so you must first uninstall SnooperStopper and then install this debug build. |
I have tried changing from PIN to password on my Android 5 phone and it worked without errors. I can't try it on Android 6 right now (I have swtiched to Copperhead OS on my Nexus 5), but I am pretty sure that I have tried it before releasing version 1.3 and it has worked (both on stock Google ROM and CyanogenMod 13). So please try to extract relevant lines from logcat. |
Case 1: Changing the password after using
|
Just wanted to add that it's definitely not just a CM13 thing: I just got this error on a Nexus 5 using stock Android 6.0.1 (MMB29V). Also, there were no spaces in my password. I did have some other non-alphanumeric characters in it though. |
@xenithorb Both Case 1 and Case 2 seems to be caused by hardware encryption (QSEECOMAPI). It seems that it doesn't work as expected in CM13 on OnePlus One. I am surprised that decryption works after this (it apparently failed to upgrade key in hardware TEE / QSEE). I am afraid I can't do much about it :-( Bug must be IMHO somewhere in Case 3 is probably because I forget to change verifypw too (I have only changed changepw). Try this new DEBUG build: |
@aibaraiduas I have tested it extensively on Nexus 5 with stock Android 6.0.1 (MMB29V) and CyanogenMod 13.0 (snapshot from 20160316) and I didn't see any problems. But it is true that I have tested only simple password without spaces or more exotic special characters. If you have any special character which can be interpreted by shell, this can really be the cause. I should add some proper escaping... |
@xmikos is it too unreliable to rely on the output of Case 4: Changing the password after changing it from within the app
Line 178-180:
Full log: http://paste.fedoraproject.org/344892/58861486 I myself am very confused as to why this scenario works. Let me try the next build then... |
Ok the new build works without issue regarding spaces What's basically left is:
I had no error since when I used debug_2 I did not use the system lockscreen settings or |
@xenithorb Thank you! Did you tried also to actually reboot device? Just to be sure that it didn't actually encrypted it with |
Btw. about that HW encryption problem... I remember reading somewhere (maybe it was in nelenkov/cryptfs-password-manager#14, but I am not sure) that |
Hmm yeah, you're right. I rebooted and couldn't decrypt. Well, now that my phone is bare, I guess I'll test out some scenarios Edit: Ok I think that's because I was being lazy about inputting the previous password on the commandline before I changed it.... Something wonky happens when you don't give it the previous password and you get |
Very strange behavior indeed, it's almost embarrassing for something so integral to the security and data of the system:
That doesn't even work btw, it's totally broken. I have no idea what the key is again. Wow. |
Hi xmikos, thanks for the new version. But this one does not work for my HTC m8. It tells me that I used the wrong password. Any ideas? |
Btw. Is it possible to do the whole process by hand? Like in ADB shell or something to have a temporary workaround until snooper stopper works for me? |
@f4stb00t This worked for me: (first set short pin lock screen, then encrypted via settings): vdc cryptfs changepw password [your pin without brackets] [YourNewSuperSecureLongPasswordWithoutBrackets] |
OmniRom 6.0.1 user here. @takiainen's method worked for me, too. |
Seems like changing the password is still not working with CM13. :( |
This is still working on LineageOs 14.1 luckily |
@utack Can you explain a bit more the process of having this app working on lineageos? I'm planning to wipe my phone and install lineage soon but I want this app to work correctly. What I'm looking for is some brief steps like |
@rodrigoaguilera did not use the app |
@utack From what I read you have to run the command every time you change the lock gesture/password. Still I find interesting the reboot after some tries features and I hope it works just by installing the app. |
before upgrading to Lineage 14.1 this month, I was using Lineage 13.x. Changing the password was broken for a while in Lineage 13.x and then later on fixed. Reboot after xx wrong PIN entries works on Lineage 13.x and 14.1 for me. |
btw: I have a second phone for development, so I could easily switch between Lineage 13.x and 14.x to reproduce issues. The 13.0 build is from 2017-04-22, the 14.1 build from 2017-06-07. |
I am experiencing the same issue in my Huawi Honor 5x (kiwi) with LineageOS-14.1-20170705-nightly-kiwi. When entering the old password in snooperstopper it says "invalid password". Unfortunately trying to change the device encryption password with the mentioned vdc command gives me: /system/bin/sh: vdc: not found I typed: vdc cryptfs changepw password myoldpin newpassword I Trier terminal emulator on the device vor shell via ADB. Both with the same error of course. |
On Thursday, 13 July 2017 12:37:27 CEST eX00r wrote:
/system/bin/sh: vdc: not found
I typed: vdc cryptfs changepw password myoldpin newpassword
the vdc binary must be there somewhere.
Did you try with a root shell?
Either use "adb root" followed by "adb shell"
from your host.
Or use "su" to become root when running the command from the phone.
Cheers,
Thomas
|
@thomasjfox thanks. When running with su from phone ( su vdc cryptfs changepw password myoldpin newpassword) terminal answers with: unknown id: vdc Will try from host later. Sent from my HUAWEI KIW-L21 using FastHub |
I think you are using "su" as if it was the "sudo" command. |
@thomasjfox thanks a lot and sorry. That worked like a charm. I have seperated the encryption password from the screenunlocking pin successfully. Sent from my HUAWEI KIW-L21 using FastHub |
while research and testing for my comment (be careful! i'm not sure if it also works for CM/LOS 13) at Cryptfs Password i came across this issue... i just have to point out one error at @xenithorb's #8 (comment):
for more explanation have a look at the bigger part of my linked comment. btw, thanks for the whole thread, it helped to understand the android-encryption-thing! |
FWIW i now run an AOSP 8.1 rom and the old |
@utack thanks for the info. if you read the bigger part of this comment this is absolutely clear (and nothing new), because whatever you type at |
Hi,
first I want to thank you for the great work. Your little Software works like a charm. I still don't get it, why Google does not implement this. Who wants to use a 30+ symbols/letters/digits Password everytime to unlock a phone...
But back to Topic. I tried Snooper Stopper on CM 13. Fist run it asks for root priviliges. I grant them, but that's all. I cannot change the Password.
Please be so kind and have a look on this.
kind regards
fastboot
The text was updated successfully, but these errors were encountered: