From 7817a30ea7c927cc1ff2b5771d11163a2f2bb9f0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Leclercq?= Date: Fri, 27 Dec 2024 12:08:13 +0100 Subject: [PATCH] SFML: Fix msvc runtime when using MTd without debug --- packages/s/sfml/xmake.lua | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/s/sfml/xmake.lua b/packages/s/sfml/xmake.lua index 2df83585646..a4c797f77ef 100644 --- a/packages/s/sfml/xmake.lua +++ b/packages/s/sfml/xmake.lua @@ -240,9 +240,8 @@ package("sfml") end else table.insert(configs, "-DBUILD_SHARED_LIBS=OFF") - if package:is_plat("windows") and package:has_runtime("MT", "MTd") then - table.insert(configs, "-DSFML_USE_STATIC_STD_LIBS=ON") - end + -- SFML overrides MSVC runtimes if set to ON, xmake already takes cares of setting it + table.insert(configs, "-DSFML_USE_STATIC_STD_LIBS=OFF") end table.insert(configs, "-DSFML_BUILD_AUDIO=" .. (package:config("audio") and "ON" or "OFF")) table.insert(configs, "-DSFML_BUILD_GRAPHICS=" .. (package:config("graphics") and "ON" or "OFF"))