Range of accepted screen values does not match

[wysiwys]

In src/keymap.h, the type of the screen member in the xkb_switch_screen_action struct is int8_t. This also matches the type specified in the X Keyboard Extension Protocol Specification for SA_SwitchScreen. However, during the validation step in src/xkbcomp/action.c, in the function HandleSwitchScreen(), all values in the range [-255, +255] are accepted.

Should the validation step instead check that the value is in [-128, +127], in order to fit inside the range of int8_t?

[wismill]

I would say the range should be -128..+127 indeed, but we parse as X11 xkbcomp does.