Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abort when augmenting key definition #564

Open
mahkoh opened this issue Dec 16, 2024 · 1 comment · May be fixed by #568
Open

Abort when augmenting key definition #564

mahkoh opened this issue Dec 16, 2024 · 1 comment · May be fixed by #568
Labels
bug Indicates an unexpected problem or unintended behavior compile-keymap Indicates a need for improvements or additions to keymap compilation
Milestone
1.8.0

Comments

@mahkoh
Copy link

mahkoh commented Dec 16, 2024

The following code triggers an assertion:

    xkb_symbols {
        key <a> { [ A ] };
        augment key <a> { [ { A, A } ], [ { SetMods(), SetMods() } ] };
    };

compile-keymap: ../src/xkbcomp/symbols.c:361: MergeGroups: Assertion `intoLevel->num_syms == fromLevel->num_syms' failed.
@wismill
Copy link
Member

wismill commented Dec 16, 2024

Good catch! We need more tests.

@wismill wismill added this to the 1.8.0 milestone Dec 16, 2024
@wismill wismill added bug Indicates an unexpected problem or unintended behavior compile-keymap Indicates a need for improvements or additions to keymap compilation labels Dec 16, 2024
This was referenced Dec 19, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior compile-keymap Indicates a need for improvements or additions to keymap compilation
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

xkbcomp: Fix key merge mode (keysyms, actions) wismill/libxkbcommon
2 participants
@mahkoh @wismill