Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.6.0 release planning #354

Closed
bluetech opened this issue Jun 30, 2023 · 9 comments
Closed

1.6.0 release planning #354

bluetech opened this issue Jun 30, 2023 · 9 comments
Assignees
Milestone

Comments

@bluetech
Copy link
Member

The plan is basically: once @wismill says we should :) Let me know you think we're in a good state in regards to your PRs (note: I do intent to go over all of them soon), then I'll do the release.

@bluetech bluetech self-assigned this Jun 30, 2023
@wismill
Copy link
Member

wismill commented Jun 30, 2023

Thank you for your trust! I would like to finish the following PR:

@whot
Copy link
Contributor

whot commented Jul 3, 2023

Not actionable until X11 xkbcomp and xkeyboard-config catch up? I do not see it in 1.6.0.

fwiw, realistically this means unless you add it to xkbcomp, it'll never happen. xkbcomp has been effectively unmaintained (functionality-wise) for decades now. And then there's the whole happy inertia game of xkeyboard-config not being able to ship rules with new features until they're wildly enough supported, which will take imperial yonks or metric ages.

I'll be trying to work my way through the others as I find time this week.

@wismill
Copy link
Member

wismill commented Jul 3, 2023

fwiw, realistically this means unless you add it to xkbcomp, it'll never happen.

I am aware of this. It may happen if:

  • The design of the :all feature is validated and merged in xkbcommon.
  • I have the guaranty that my potential work of X11 xkbcomp will be revised this year and, if validated, a release will follow soon after. I am OK to wait a few months for a review, but I will not find the motivation if there is nobody supporting this improvement.

there's the whole happy inertia game of xkeyboard-config not being able to ship rules with new features until they're wildly enough supported

Backward compatibility is mandatory and motivates changes to xkbcomp. I would wait a few xkeyboard-config releases after the xkbcomp one before proposing making use of the new feature, with a big warning in the release notes. I believe that communication to the main distros and the excellent QA of some of them (see e.g. openSUSE) should make the transition possible.

The feature is worth the effort.

@wismill wismill added this to the 1.6.0 milestone Jul 3, 2023
@whot
Copy link
Contributor

whot commented Jul 4, 2023

I have the guaranty that my potential work of X11 xkbcomp will be revised this year and, if validated, a release will follow soon after.

be careful what you wish for, you may just become the maintainer of xkbcomp if you do that :)
but after a very quick skim of #334 I think this may be a lot more "involved". IIRC xkbcomp doesn't do anything with the rules files directly, you're looking at libxkbfile and possibly libxklavier, both of which are woefully unmaintained but still required in various components - like the X server. I don't know off-hand whether there are any other projects parsing the rules files that would need to be fixed. Anyway - this comes down to: fixing libxkbfile instead of xkbcomp might get you 90% of the way there (and means you'll become the maintainer of libxkbfile ;)

@wismill
Copy link
Member

wismill commented Sep 28, 2023

@bluetech @whot currently almost all the items in the 1.6.0 milestone have been processed. We are close to a release.

As you can see there are still a few PR pending. I wish #356 could make it for this release, but I think further delaying the release is maybe not a good idea. So I already planned some PR for the future 1.7.0 release.

Now, I would like to know how do you proceed with release:

  • How do you update the NEWS file? I guess you use the git history, but do you use a tool?
  • Is there any other step before cutting the release?
  • How do you proceed with the release tag?
  • What are the next steps? I guess:
    • making a Github release
    • making a tarball and upload it to the website
    • send the announcement in the wayland-dev mailing list

I would like to help to make the release.

@bluetech
Copy link
Member Author

bluetech commented Sep 28, 2023

How do you update the NEWS file? I guess you use the git history, but do you use a tool?

I don't use a tool, I just go over the commits.

Is there any other step before cutting the release?

Here's how I do it, it's somewhat laborious.

  • Write the NEWS, update the version in meson.build, tag the release with git tag -a xkbcommon-1.6.0 -m xkbcommon-1.6.0.
  • Run meson dist
  • Upload the tarball to the server (SSH)
  • Upload the version docs to the server, change the current symlink to point to it
  • Push the tag to the repo
  • Send email announcement to wayland-devel (this includes the NEWS and the sha256sum from meson dist)
  • Update https://github.com/xkbcommon/website with the release, commit & push to repo
  • Update the index.html on the server
  • Create github release

@wismill
Copy link
Member

wismill commented Sep 28, 2023

Thanks for clarifying the steps.

The Github pages job is working quite nice. I wonder when could we switch the entire website (see #326).

Once we have switched to Github page-base website, we could write a manual job that deploy the release. Then the workflow would be:

  1. Write the NEWS file
  2. Update the version in meson.build, tag the release and push.
  3. Run the release job
  4. Create a Github release (could it be done with the previous job?)
  5. Send the email annoucement.

I changed a bit the order, that seems more practical to me.

@bluetech
Copy link
Member Author

The Github pages job is working quite nice. I wonder when could we switch the entire website (see #326).

The two tasks here are:

After that it's just a matter of changing the DNS I think.

Once we have switched to Github page-base website, we could write a manual job that deploy the release. Then the workflow would be [...]

This sounds good to me.

In the meantime, I can handle the 1.6.0, it's not a problem. I see you've added a couple more PRs to the 1.6.0 milestone so I'll wait for them. Let me know if you want to write the NEWS for this release, otherwise I'll write it and send a PR.

@bluetech
Copy link
Member Author

bluetech commented Oct 8, 2023

1.6.0 is released!

@bluetech bluetech closed this as completed Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants