Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ogg M4 script ignores sysroot setting #89

Open
dos1 opened this issue Dec 28, 2018 · 6 comments
Open

Ogg M4 script ignores sysroot setting #89

dos1 opened this issue Dec 28, 2018 · 6 comments

Comments

@dos1
Copy link

dos1 commented Dec 28, 2018

When cross-compiling and invoking configure with parameters like --with-sysroot=/foo --prefix=/usr, FLAC finds libogg installed in host's /usr, adding it to include path and wreaking havok.

Looking into ogg.m4, it seems like while $prefix is one of the places being checked, it doesn't include the sysroot at all. I don't know much about autotools, but replacing things like OGG_LIBS="-L$prefix/lib" with OGG_LIBS="-L$sysroot/$prefix/lib" might be enough.

A workaround is to specify path manually using --with-ogg.

@erikd
Copy link
Member

erikd commented Dec 29, 2018

Things like --with-ogg are specifically intended for situations like cross compiling.

I don't really think there is anything here that needs fixing.

@dos1
Copy link
Author

dos1 commented Dec 29, 2018

Really? It doesn't really feel elegant, as specifying --with-sysroot should usually provide enough data to correctly find all dependencies while cross compiling (unless Ogg has been installed to non-standard location, but that can happen without cross compiling as well). Repeating the path manually for each dependency (in this case just one, but you get the point :P) seems redundant.

@erikd
Copy link
Member

erikd commented Dec 29, 2018

Well patch accepted.

@neheb
Copy link
Contributor

neheb commented Aug 31, 2019

I would guess this is not the case with CMake?

@erikd
Copy link
Member

erikd commented Sep 2, 2019

I would guess this is not the case with CMake?

Sorry, wat? That question is highly ambiguous. Care to clarify?

@ktmf01
Copy link
Collaborator

ktmf01 commented Jun 24, 2022

@rillian Should this issue be transferred to the ogg repository? It might be other projects depending on libogg are affected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants