-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wave64 metadata application ID should be 0x77363420 #761
Comments
Thanks! I'll have it fixed.
That repo is very much out of date, it should mirror the one at https://gitlab.xiph.org/xiph/flac-website but doesn't. |
You were just in time. This document is about to be published, and it was still possible to change this. One week later, and it would have been an erratum instead of a change. |
Nice! |
It is still on the website, but that table will be removed as soon as the document is published, so I won't bother updating it. I'll keep this issue open until that is done however, as a reminder. |
Wave64 metadata application ID should be 0x77363420, instead of 0x773634C0. The last character is a space, thus has the value 0x20.
The source has always used a space:
https://github.com/xiph/flac/blob/master/src/flac/foreign_metadata.c#L38
src/flac/foreign_metadata.c:38:const char *FLAC__FOREIGN_METADATA_APPLICATION_ID[FLAC__FOREIGN_METADATA_NUMBER_OF_RECOGNIZED_APPLICATION_IDS] = { "aiff" , "riff", "w64 " };
The ID is mentioned in the documentation:
https://github.com/xiph/flac/blob/master/doc/foreign_metadata_storage.md?plain=1#L6
Also on the webpage:
https://xiph.org/flac/id.html
But seems to be missing from the website repo? There is no "w64 " or "FLAC Wave64 chunk storage":
https://github.com/xiph/flac-website/blob/main/id.html
The text was updated successfully, but these errors were encountered: