Add droneci, fix linter errors

Author: echa

.drone.yml

@@ -0,0 +1,34 @@
+kind: pipeline
+name: TzGo Pipeline
+platform:
+  os: linux
+  arch: amd64
+
+trigger:
+  event:
+    - push
+#  paths:
+#    include:
+#      - README.md
+
+environment:
+  CGO_ENABLED: 0
+
+steps:
+- name: run linter
+  image: golangci/golangci-lint:v1.45-alpine
+  commands:
+    - golangci-lint run
+
+- name: scan the files
+  image: aquasec/trivy:0.24.3
+  commands:
+    - trivy fs --exit-code 1 --security-checks vuln,config ./
+    - trivy config --exit-code 1 ./
+
+- name: go build
+  image: golang:1.19.0-alpine3.16
+  commands:
+    - go vet ./...
+    - go test ./...
+    - go build ./examples/...

.golangci.yml

@@ -0,0 +1,17 @@
+linters:
+  enable:
+    - bodyclose
+    - goconst
+    - gocritic
+    - gofmt
+    - govet
+    - prealloc
+    - unconvert
+    - unparam
+    - deadcode
+    - gosimple
+    - structcheck
+    - varcheck
+    - unused
+  disable:
+    - errcheck

README.md

@@ -1,5 +1,7 @@
 ## TzGo – Go SDK for Tezos by Blockwatch Data
 
+[![Build Status](https://drone.bwd.cx/api/badges/blockwatch-cc/poly/status.svg?ref=refs/heads/kuba/droneCI)](https://drone.bwd.cx/blockwatch-cc/poly)
+
 TzGo is the officially supported Tezos Go client library by [Blockwatch](https://blockwatch.cc). This SDK is free to use in commercial and non-commercial projects with a permissive license. Blockwatch is committed to keeping interfaces stable, providing long-term support, and updating TzGo on a regular basis to stay compliant with the most recent Tezos network protocol.
 
 Our main focus is on **correctness**, **stability**, and **compliance** with the Tezos protocol. TzGo supports binary and JSON encodings for all Tezos types including the Micheline smart contract data and all transaction formats so it's perfectly suited for high-performance applications that read and write to the Tezos blockchain.
@@ -371,4 +373,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-THE SOFTWARE.
+THE SOFTWARE.

base58/base58check.go

@@ -34,12 +34,11 @@ func checksum(input []byte) (cksum [4]byte) {
 func CheckEncode(input []byte, version []byte) string {
 	bi := bufPool.Get()
 	b := bi.([]byte)[:0]
-	b = append(b, version[:]...)
-	b = append(b, input[:]...)
+	b = append(b, version...)
+	b = append(b, input...)
 	cksum := checksum(b)
 	b = append(b, cksum[:]...)
 	res := Encode(b)
-	b = b[:0]
 	bufPool.Put(bi)
 	return res
 }

base58/base58check_test.go

@@ -38,11 +38,12 @@ func TestBase58Check(t *testing.T) {
 
 		// test decoding
 		res, version, err := base58.CheckDecode(test.out, 1, nil)
-		if err != nil {
+		switch {
+		case err != nil:
 			t.Errorf("CheckDecode test #%d failed with err: %v", x, err)
-		} else if version[0] != test.version {
+		case version[0] != test.version:
 			t.Errorf("CheckDecode test #%d failed: got version: %d want: %d", x, version, test.version)
-		} else if string(res) != test.in {
+		case string(res) != test.in:
 			t.Errorf("CheckDecode test #%d failed: got: %s want: %s", x, res, test.in)
 		}
 	}
@@ -57,7 +58,7 @@ func TestBase58Check(t *testing.T) {
 	// bytes are missing).
 	testString := ""
 	for len := 0; len < 4; len++ {
-		testString = testString + "x"
+		testString += "x"
 		_, _, err = base58.CheckDecode(testString, 1, nil)
 		if err != base58.ErrInvalidFormat {
 			t.Error("Checkdecode test failed, expected ErrInvalidFormat")

codec/activate_account.go

@@ -4,67 +4,67 @@
 package codec
 
 import (
-    "bytes"
-    "fmt"
-    "io"
-    "strconv"
+	"bytes"
+	"fmt"
+	"io"
+	"strconv"
 
-    "blockwatch.cc/tzgo/tezos"
+	"blockwatch.cc/tzgo/tezos"
 )
 
 // ActivateAccount represents "activate_account" operation
 type ActivateAccount struct {
-    Simple
-    PublicKeyHash tezos.Address  `json:"pkh"`
-    Secret        tezos.HexBytes `json:"secret"`
+	Simple
+	PublicKeyHash tezos.Address  `json:"pkh"`
+	Secret        tezos.HexBytes `json:"secret"`
 }
 
 func (o ActivateAccount) Kind() tezos.OpType {
-    return tezos.OpTypeActivateAccount
+	return tezos.OpTypeActivateAccount
 }
 
 func (o ActivateAccount) MarshalJSON() ([]byte, error) {
-    buf := bytes.NewBuffer(nil)
-    buf.WriteByte('{')
-    buf.WriteString(`"kind":`)
-    buf.WriteString(strconv.Quote(o.Kind().String()))
-    buf.WriteString(`,"pkh":`)
-    buf.WriteString(strconv.Quote(o.PublicKeyHash.String()))
-    buf.WriteString(`,"secret":`)
-    buf.WriteString(strconv.Quote(o.Secret.String()))
-    buf.WriteByte('}')
-    return buf.Bytes(), nil
+	buf := bytes.NewBuffer(nil)
+	buf.WriteByte('{')
+	buf.WriteString(`"kind":`)
+	buf.WriteString(strconv.Quote(o.Kind().String()))
+	buf.WriteString(`,"pkh":`)
+	buf.WriteString(strconv.Quote(o.PublicKeyHash.String()))
+	buf.WriteString(`,"secret":`)
+	buf.WriteString(strconv.Quote(o.Secret.String()))
+	buf.WriteByte('}')
+	return buf.Bytes(), nil
 }
 
 func (o ActivateAccount) EncodeBuffer(buf *bytes.Buffer, p *tezos.Params) error {
-    buf.WriteByte(o.Kind().TagVersion(p.OperationTagsVersion))
-    buf.Write(o.PublicKeyHash.Hash) // only place where a 20 byte address is used (!)
-    buf.Write(o.Secret.Bytes())
-    return nil
+	buf.WriteByte(o.Kind().TagVersion(p.OperationTagsVersion))
+	buf.Write(o.PublicKeyHash.Hash) // only place where a 20 byte address is used (!)
+	buf.Write(o.Secret.Bytes())
+	return nil
 }
 
 func (o *ActivateAccount) DecodeBuffer(buf *bytes.Buffer, p *tezos.Params) error {
-    if err := ensureTagAndSize(buf, o.Kind(), p.OperationTagsVersion); err != nil {
-        return err
-    }
-    o.PublicKeyHash = tezos.NewAddress(tezos.AddressTypeEd25519, buf.Next(20))
-    if !o.PublicKeyHash.IsValid() {
-        return fmt.Errorf("invalid address type=%s len=%d", o.PublicKeyHash.Type, len(o.PublicKeyHash.Hash))
-    }
-    o.Secret = make([]byte, 20)
-    copy(o.Secret, buf.Next(20))
-    if len(o.Secret) != 20 {
-        return io.ErrShortBuffer
-    }
-    return nil
+	if err := ensureTagAndSize(buf, o.Kind(), p.OperationTagsVersion); err != nil {
+		return err
+	}
+	o.PublicKeyHash = tezos.NewAddress(tezos.AddressTypeEd25519, buf.Next(20))
+	if !o.PublicKeyHash.IsValid() {
+		return fmt.Errorf("invalid address type=%s len=%d", o.PublicKeyHash.Type, len(o.PublicKeyHash.Hash))
+	}
+	o.Secret = make([]byte, 20)
+	copy(o.Secret, buf.Next(20))
+	if len(o.Secret) != 20 {
+		return io.ErrShortBuffer
+	}
+	return nil
 }
 
 func (o ActivateAccount) MarshalBinary() ([]byte, error) {
-    buf := bytes.NewBuffer(nil)
-    err := o.EncodeBuffer(buf, tezos.DefaultParams)
-    return buf.Bytes(), err
+	buf := bytes.NewBuffer(nil)
+	err := o.EncodeBuffer(buf, tezos.DefaultParams)
+	return buf.Bytes(), err
 }
 
 func (o *ActivateAccount) UnmarshalBinary(data []byte) error {
-    return o.DecodeBuffer(bytes.NewBuffer(data), tezos.DefaultParams)
+	return o.DecodeBuffer(bytes.NewBuffer(data), tezos.DefaultParams)
 }

codec/ballot.go

@@ -4,78 +4,78 @@
 package codec
 
 import (
-    "bytes"
-    "encoding/binary"
-    "strconv"
+	"bytes"
+	"encoding/binary"
+	"strconv"
 
-    "blockwatch.cc/tzgo/tezos"
+	"blockwatch.cc/tzgo/tezos"
 )
 
 // Ballot represents "ballot" operation
 type Ballot struct {
-    Simple
-    Source   tezos.Address      `json:"source"`
-    Period   int32              `json:"period"`
-    Proposal tezos.ProtocolHash `json:"proposal"`
-    Ballot   tezos.BallotVote   `json:"ballot"`
+	Simple
+	Source   tezos.Address      `json:"source"`
+	Period   int32              `json:"period"`
+	Proposal tezos.ProtocolHash `json:"proposal"`
+	Ballot   tezos.BallotVote   `json:"ballot"`
 }
 
 func (o Ballot) Kind() tezos.OpType {
-    return tezos.OpTypeBallot
+	return tezos.OpTypeBallot
 }
 
 func (o Ballot) MarshalJSON() ([]byte, error) {
-    buf := bytes.NewBuffer(nil)
-    buf.WriteByte('{')
-    buf.WriteString(`"kind":`)
-    buf.WriteString(strconv.Quote(o.Kind().String()))
-    buf.WriteString(`,"source":`)
-    buf.WriteString(strconv.Quote(o.Source.String()))
-    buf.WriteString(`,"period":`)
-    buf.WriteString(strconv.Itoa(int(o.Period)))
-    buf.WriteString(`,"proposal":`)
-    buf.WriteString(strconv.Quote(o.Proposal.String()))
-    buf.WriteString(`,"ballot":`)
-    buf.WriteString(strconv.Quote(o.Ballot.String()))
-    buf.WriteByte('}')
-    return buf.Bytes(), nil
+	buf := bytes.NewBuffer(nil)
+	buf.WriteByte('{')
+	buf.WriteString(`"kind":`)
+	buf.WriteString(strconv.Quote(o.Kind().String()))
+	buf.WriteString(`,"source":`)
+	buf.WriteString(strconv.Quote(o.Source.String()))
+	buf.WriteString(`,"period":`)
+	buf.WriteString(strconv.Itoa(int(o.Period)))
+	buf.WriteString(`,"proposal":`)
+	buf.WriteString(strconv.Quote(o.Proposal.String()))
+	buf.WriteString(`,"ballot":`)
+	buf.WriteString(strconv.Quote(o.Ballot.String()))
+	buf.WriteByte('}')
+	return buf.Bytes(), nil
 }
 
 func (o Ballot) EncodeBuffer(buf *bytes.Buffer, p *tezos.Params) error {
-    buf.WriteByte(o.Kind().TagVersion(p.OperationTagsVersion))
-    buf.Write(o.Source.Bytes())
-    binary.Write(buf, enc, o.Period)
-    buf.Write(o.Proposal.Bytes())
-    buf.WriteByte(o.Ballot.Tag())
-    return nil
+	buf.WriteByte(o.Kind().TagVersion(p.OperationTagsVersion))
+	buf.Write(o.Source.Bytes())
+	binary.Write(buf, enc, o.Period)
+	buf.Write(o.Proposal.Bytes())
+	buf.WriteByte(o.Ballot.Tag())
+	return nil
 }
 
 func (o *Ballot) DecodeBuffer(buf *bytes.Buffer, p *tezos.Params) (err error) {
-    if err = ensureTagAndSize(buf, o.Kind(), p.OperationTagsVersion); err != nil {
-        return
-    }
-    if err = o.Source.UnmarshalBinary(buf.Next(21)); err != nil {
-        return
-    }
-    o.Period, err = readInt32(buf.Next(4))
-    if err != nil {
-        return
-    }
-    if err = o.Proposal.UnmarshalBinary(buf.Next(32)); err != nil {
-        return
-    }
-    if err = o.Ballot.UnmarshalBinary(buf.Next(1)); err != nil {
-        return
-    }
-    return nil
+	if err = ensureTagAndSize(buf, o.Kind(), p.OperationTagsVersion); err != nil {
+		return
+	}
+	if err = o.Source.UnmarshalBinary(buf.Next(21)); err != nil {
+		return
+	}
+	o.Period, err = readInt32(buf.Next(4))
+	if err != nil {
+		return
+	}
+	if err = o.Proposal.UnmarshalBinary(buf.Next(32)); err != nil {
+		return
+	}
+	if err = o.Ballot.UnmarshalBinary(buf.Next(1)); err != nil {
+		return
+	}
+	return nil
 }
 
 func (o Ballot) MarshalBinary() ([]byte, error) {
-    buf := bytes.NewBuffer(nil)
-    err := o.EncodeBuffer(buf, tezos.DefaultParams)
-    return buf.Bytes(), err
+	buf := bytes.NewBuffer(nil)
+	err := o.EncodeBuffer(buf, tezos.DefaultParams)
+	return buf.Bytes(), err
 }
 
 func (o *Ballot) UnmarshalBinary(data []byte) error {
-    return o.DecodeBuffer(bytes.NewBuffer(data), tezos.DefaultParams)
+	return o.DecodeBuffer(bytes.NewBuffer(data), tezos.DefaultParams)
 }