Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all notebooks to test #98

Open
shihchengli opened this issue May 29, 2024 · 1 comment · Fixed by #100
Open

Add all notebooks to test #98

shihchengli opened this issue May 29, 2024 · 1 comment · Fixed by #100
Labels
enhancement New feature or request good first issue Good for newcomers unit test

Comments

@shihchengli
Copy link
Collaborator

shihchengli commented May 29, 2024 •
edited
Loading

Currently, when a notebook run fails, CI doesn't complain.
Adding pytest --no-cov -v --nbmake ipython/*.ipynb into ci.yaml file can support it.
@xiaoruiDong xiaoruiDong added enhancement New feature or request good first issue Good for newcomers unit test labels May 29, 2024
@xiaoruiDong
Copy link
Owner

Thanks for bringing this up. I like this idea and will try to incorporate it into CI.

@shihchengli shihchengli mentioned this issue Jul 15, 2024
Merged
@shihchengli shihchengli linked a pull request Jul 15, 2024 that will close this issue
Add notebooks to test in CI #100
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers unit test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add notebooks to test in CI shihchengli/RDMC
2 participants
@xiaoruiDong @shihchengli