From f20cf28da6a345ed0a5ca8167fdbf2c9b3f7d48c Mon Sep 17 00:00:00 2001 From: Michal Dybizbanski Date: Tue, 13 Aug 2024 17:07:42 +0200 Subject: [PATCH] XEOK-93 Correctly remove AngleMeasurementsMouseControl and DistanceMeasurementsMouseControl dot --- .../AngleMeasurementsMouseControl.js | 6 ++---- .../DistanceMeasurementsMouseControl.js | 6 ++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/plugins/AngleMeasurementsPlugin/AngleMeasurementsMouseControl.js b/src/plugins/AngleMeasurementsPlugin/AngleMeasurementsMouseControl.js index 6c957ff615..f53b8a2483 100644 --- a/src/plugins/AngleMeasurementsPlugin/AngleMeasurementsMouseControl.js +++ b/src/plugins/AngleMeasurementsPlugin/AngleMeasurementsMouseControl.js @@ -74,7 +74,6 @@ export class AngleMeasurementsMouseControl extends AngleMeasurementsControl { _initMarkerDiv() { const markerDiv = document.createElement('div'); - markerDiv.setAttribute('id', 'myMarkerDiv'); const canvas = this.scene.canvas.canvas; canvas.parentNode.insertBefore(markerDiv, canvas); @@ -95,9 +94,8 @@ export class AngleMeasurementsMouseControl extends AngleMeasurementsControl { _destroyMarkerDiv() { if (this.markerDiv) { - const element = document.getElementById('myMarkerDiv') - element.parentNode.removeChild(element) - this.markerDiv = null + this.markerDiv.parentNode.removeChild(this.markerDiv); + this.markerDiv = null; } } diff --git a/src/plugins/DistanceMeasurementsPlugin/DistanceMeasurementsMouseControl.js b/src/plugins/DistanceMeasurementsPlugin/DistanceMeasurementsMouseControl.js index 4f096fd09b..603e5ef9d4 100644 --- a/src/plugins/DistanceMeasurementsPlugin/DistanceMeasurementsMouseControl.js +++ b/src/plugins/DistanceMeasurementsPlugin/DistanceMeasurementsMouseControl.js @@ -82,7 +82,6 @@ export class DistanceMeasurementsMouseControl extends DistanceMeasurementsContro _initMarkerDiv() { const markerDiv = document.createElement('div'); - markerDiv.setAttribute('id', 'myMarkerDiv'); const canvas = this.scene.canvas.canvas; canvas.parentNode.insertBefore(markerDiv, canvas); markerDiv.style.background = "black"; @@ -102,9 +101,8 @@ export class DistanceMeasurementsMouseControl extends DistanceMeasurementsContro _destroyMarkerDiv() { if (this._markerDiv) { - const element = document.getElementById('myMarkerDiv') - element.parentNode.removeChild(element) - this._markerDiv = null + this._markerDiv.parentNode.removeChild(this._markerDiv); + this._markerDiv = null; } }