Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually featuring (or unfeaturing) threads #22

Open
Myke623 opened this issue Oct 19, 2017 · 0 comments
Open

Manually featuring (or unfeaturing) threads #22

Myke623 opened this issue Oct 19, 2017 · 0 comments

Comments

@Myke623
Copy link

Myke623 commented Oct 19, 2017

In the Manually featuring (or unfeaturing) threads section and in specific reference to the paragraph that begins with:

We can now move on to changing the thread editor service...

I initially found the sequence of introducing these two new class extensions to be a little confusing to follow. In the docs up until this point, one could effectively "follow the bouncing ball" with the instructions. That is, you can read a bit, do a bit, read a bit, do a bit, in a linear fashion. With the creation of new class extensions, the instructions generally followed a pattern of:

  1. (ACP) Create (but don't save) new class extension
  2. (IDE) Create code
  3. (ACP) Save class extension

So the workflow demonstrated up to this point had you going from the ACP, then to your dev environment and finally back to the ACP.

But in the aforementioned paragraph, this pattern isn't followed. The definitions for the two class extensions are provided first, then the code for the second class extension is shown. In my following the bouncing ball approach, I had the first class extension (XF\Pub\Controller\Thread) pre-populated in the ACP but was then introduced to the code for the second class extension (XF\Service\Thread\Editor).

Reading forward and backtracking was necessary to eventually create the two new class extensions, and had me initially stumped. This sub-section could perhaps be restructured so that it's consistent with the new class creation workflow used throughout the guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant