[WIP] dom0: add possibility to use Domu without GSX #127
Conversation
|
Successfully built and ran on |
| cat ${WORKDIR}/domu-vdevices.cfg >> ${CFG_FILE} | ||
| cat ${WORKDIR}/pvr-${XT_DOMU_CONFIG_NAME} >> ${CFG_FILE} | ||
| if ${@bb.utils.contains('MACHINE_FEATURES', 'gsx', 'true', 'false', d)}; then | ||
| cat ${WORKDIR}/domu-vdevices.cfg >> ${CFG_FILE} |
There was a problem hiding this comment.
I'd better removed gsx from domu-vdevices and added domu-vdevices-gsx. Idea is that you always include domu-vdevicesand adddomu-devices-gsx` conditionally.
| # Note2: | ||
| # Option `target` must be last element in list. For explanation see | ||
| # https://xenbits.xenproject.org/docs/4.15-testing/man/xl-disk-configuration.5.html | ||
| disk = [ 'backend=DomD, vdev=xvda1, target=/dev/STORAGE_PART3' ] |
There was a problem hiding this comment.
... approach described in the other command will ensure that there will be duplicate entries like this.
rshym
force-pushed
the
mr_domunogsx
branch
3 times, most recently
from
b651115 to
4a7a3b6
Compare
|
I have reworked PR.
Tested by the build-and-run |
rshym
changed the title
| # inside `dtdev = []` construction because we will use | ||
| # linux's echo command to put multiline string into domu.cfg | ||
| python () { | ||
| if d.getVar("XT_DOMU_CONFIG_NAME", True) == "domu-generic-h3-4x2g.cfg": |
There was a problem hiding this comment.
This looks fragile.
I'd prefer to see use of flags here instead of inline python. Something like
'/soc/gsx_pv0_domu',
'/soc/gsx_pv1_domu',
'/soc/gsx_pv2_domu',
'/soc/gsx_pv3_domu',
and then some logic (maybe even inline python, okay) that choose either m3 or h3
| cat ${WORKDIR}/pvr-${XT_DOMU_CONFIG_NAME} >> ${CFG_FILE} | ||
| if ${@bb.utils.contains('MACHINE_FEATURES', 'gsx', 'true', 'false', d)}; then | ||
| cat ${WORKDIR}/gsx-common.cfg >> ${CFG_FILE} | ||
| sed -i "s/cma=32M/cma=256M pvrsrvkm.DriverMode=1/g" ${CFG_FILE} |
There was a problem hiding this comment.
We had many issues with sed earlier. I'd prefer some other solution. If you already building part of config dynamically in this recipe, you may build commandline as well.
rshym
changed the title
GSX-related configs are separated and are moved into gsx-common.cfg. The SOC-specific GSX options are added at compile time. The 'gsx' MACHINE_FEATURE is required to generate proper configuration files for domains. Signed-off-by: Ruslan Shymkevych <[email protected]>
This commit adds console only build for DomD and DomU. Signed-off-by: Ruslan Shymkevych <[email protected]>
The 'gsx' MACHINE_FEATURE is used to generate proper configuration files for domains.